[PATCH]: PPC_OF protect USB driver...

[PATCH]: PPC_OF protect USB driver...

[David Miller]

This uses APIs that are not generic, or at least not part of
what Sparc provides yet.

So just PPC_OF this for now just like the EHCI_OF driver.

This fixes allmodconfig build errors on sparc.

Signed-off-by: David S. Miller <davem@davemloft.net>

diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
index 33b467a..1ef6df3 100644
--- a/drivers/usb/host/Kconfig
+++ b/drivers/usb/host/Kconfig
@@ -129,7 +129,7 @@ config USB_ISP1760_PCI
 
 config USB_ISP1760_OF
 	bool "Support for the OF platform bus"
-	depends on USB_ISP1760_HCD && OF
+	depends on USB_ISP1760_HCD && PPC_OF
 	---help---
 	  Enables support for the device present on the PowerPC
 	  OpenFirmware platform bus.

Re: [PATCH]: PPC_OF protect USB driver...

[Benjamin Herrenschmidt]

On Mon, 2008-05-05 at 00:57 -0700, David Miller wrote:
> This uses APIs that are not generic, or at least not part of
> what Sparc provides yet.
> 
> So just PPC_OF this for now just like the EHCI_OF driver.
> 
> This fixes allmodconfig build errors on sparc.
> 
> Signed-off-by: David S. Miller <davem@davemloft.net>

Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---

> 
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 33b467a..1ef6df3 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -129,7 +129,7 @@ config USB_ISP1760_PCI
>  
>  config USB_ISP1760_OF
>  	bool "Support for the OF platform bus"
> -	depends on USB_ISP1760_HCD && OF
> +	depends on USB_ISP1760_HCD && PPC_OF
>  	---help---
>  	  Enables support for the device present on the PowerPC
>  	  OpenFirmware platform bus.
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev

Re: [PATCH]: PPC_OF protect USB driver...

[Paul Mackerras]

David Miller writes:

> This uses APIs that are not generic, or at least not part of
> what Sparc provides yet.
> 
> So just PPC_OF this for now just like the EHCI_OF driver.
> 
> This fixes allmodconfig build errors on sparc.

Are you going to send this to the USB maintainers, or are you going to
merge it to Linus, or do you want me to?

Paul.

Re: [PATCH]: PPC_OF protect USB driver...

[David Miller]

From: Paul Mackerras <paulus@samba.org>
Date: Fri, 9 May 2008 15:27:37 +1000

> David Miller writes:
> 
> > This uses APIs that are not generic, or at least not part of
> > what Sparc provides yet.
> > 
> > So just PPC_OF this for now just like the EHCI_OF driver.
> > 
> > This fixes allmodconfig build errors on sparc.
> 
> Are you going to send this to the USB maintainers, or are you going to
> merge it to Linus, or do you want me to?

It is in Linus's tree after a sparc push I sent to him yesterday.

Thanks Paul.