linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] POWERPC: Get rid of leftover printk in isa-bridge.c
@ 2008-05-08 16:41 Nate Case
  2008-05-09  4:31 ` Benjamin Herrenschmidt
  0 siblings, 1 reply; 2+ messages in thread
From: Nate Case @ 2008-05-08 16:41 UTC (permalink / raw)
  To: kernel-janitors; +Cc: linuxppc-dev

This printk() appears twice in the same function.  Only the latter one
in the inval_range: section appears to be legitimate.

Signed-off-by: Nate Case <ncase@xes-inc.com>
---

diff --git a/arch/powerpc/kernel/isa-bridge.c b/arch/powerpc/kernel/isa-bridge.c
index ee172aa..e35092e 100644
--- a/arch/powerpc/kernel/isa-bridge.c
+++ b/arch/powerpc/kernel/isa-bridge.c
@@ -108,9 +108,6 @@ static void __devinit pci_process_ISA_OF_ranges(struct device_node *isa_node,
 	if (size > 0x10000)
 		size = 0x10000;
 
-	printk(KERN_ERR "no ISA IO ranges or unexpected isa range, "
-	       "mapping 64k\n");
-
 	__ioremap_at(phb_io_base_phys, (void *)ISA_IO_BASE,
 		     size, _PAGE_NO_CACHE|_PAGE_GUARDED);
 	return;

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] POWERPC: Get rid of leftover printk in isa-bridge.c
  2008-05-08 16:41 [PATCH] POWERPC: Get rid of leftover printk in isa-bridge.c Nate Case
@ 2008-05-09  4:31 ` Benjamin Herrenschmidt
  0 siblings, 0 replies; 2+ messages in thread
From: Benjamin Herrenschmidt @ 2008-05-09  4:31 UTC (permalink / raw)
  To: Nate Case; +Cc: linuxppc-dev, kernel-janitors


On Thu, 2008-05-08 at 11:41 -0500, Nate Case wrote:
> This printk() appears twice in the same function.  Only the latter one
> in the inval_range: section appears to be legitimate.
> 
> Signed-off-by: Nate Case <ncase@xes-inc.com>

Ack.

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-05-09  4:31 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-08 16:41 [PATCH] POWERPC: Get rid of leftover printk in isa-bridge.c Nate Case
2008-05-09  4:31 ` Benjamin Herrenschmidt

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).