* [patch 1/1] fsldma: the MPC8377MDS board device tree node for fsldma driver
@ 2008-05-14 23:17 akpm
2008-05-14 23:28 ` Scott Wood
0 siblings, 1 reply; 5+ messages in thread
From: akpm @ 2008-05-14 23:17 UTC (permalink / raw)
To: paulus; +Cc: shannon.nelson, linuxppc-dev, galak, akpm, dan.j.williams,
wei.zhang
From: Zhang Wei <wei.zhang@freescale.com>
The fsldma driver is tested on MPC8377MDS board. The patch adds fsldma driver
support into MPC8377MDS device tree.
Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
Cc: "Nelson, Shannon" <shannon.nelson@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Kumar Gala <galak@gate.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
arch/powerpc/boot/dts/mpc8377_mds.dts | 27 ++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff -puN arch/powerpc/boot/dts/mpc8377_mds.dts~fsldma-the-mpc8377mds-board-device-tree-node-for-fsldma-driver arch/powerpc/boot/dts/mpc8377_mds.dts
--- a/arch/powerpc/boot/dts/mpc8377_mds.dts~fsldma-the-mpc8377mds-board-device-tree-node-for-fsldma-driver
+++ a/arch/powerpc/boot/dts/mpc8377_mds.dts
@@ -295,6 +295,33 @@
};
};
+ dma@82a8 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "fsl,mpc8349-dma";
+ reg = <0x82a8 4>;
+ ranges = <0 0x8100 0x1a8>;
+ interrupt-parent = <&ipic>;
+ interrupts = <0x47 8>;
+ cell-index = <0>;
+ dma-channel@0 {
+ compatible = "fsl,mpc8349-dma-channel";
+ reg = <0 0x80>;
+ };
+ dma-channel@80 {
+ compatible = "fsl,mpc8349-dma-channel";
+ reg = <0x80 0x80>;
+ };
+ dma-channel@100 {
+ compatible = "fsl,mpc8349-dma-channel";
+ reg = <0x100 0x80>;
+ };
+ dma-channel@180 {
+ compatible = "fsl,mpc8349-dma-channel";
+ reg = <0x180 0x28>;
+ };
+ };
+
/* IPIC
* interrupts cell = <intr #, sense>
* sense values match linux IORESOURCE_IRQ_* defines:
_
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [patch 1/1] fsldma: the MPC8377MDS board device tree node for fsldma driver
2008-05-14 23:17 [patch 1/1] fsldma: the MPC8377MDS board device tree node for fsldma driver akpm
@ 2008-05-14 23:28 ` Scott Wood
2008-05-14 23:36 ` Dan Williams
0 siblings, 1 reply; 5+ messages in thread
From: Scott Wood @ 2008-05-14 23:28 UTC (permalink / raw)
To: akpm; +Cc: shannon.nelson, linuxppc-dev, paulus, galak, dan.j.williams,
wei.zhang
akpm@linux-foundation.org wrote:
> From: Zhang Wei <wei.zhang@freescale.com>
>
> The fsldma driver is tested on MPC8377MDS board. The patch adds fsldma driver
> support into MPC8377MDS device tree.
>
> Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
> Cc: "Nelson, Shannon" <shannon.nelson@intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Kumar Gala <galak@gate.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> arch/powerpc/boot/dts/mpc8377_mds.dts | 27 ++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
>
> diff -puN arch/powerpc/boot/dts/mpc8377_mds.dts~fsldma-the-mpc8377mds-board-device-tree-node-for-fsldma-driver arch/powerpc/boot/dts/mpc8377_mds.dts
> --- a/arch/powerpc/boot/dts/mpc8377_mds.dts~fsldma-the-mpc8377mds-board-device-tree-node-for-fsldma-driver
> +++ a/arch/powerpc/boot/dts/mpc8377_mds.dts
> @@ -295,6 +295,33 @@
> };
> };
>
> + dma@82a8 {
> + #address-cells = <1>;
> + #size-cells = <1>;
> + compatible = "fsl,mpc8349-dma";
> + reg = <0x82a8 4>;
> + ranges = <0 0x8100 0x1a8>;
> + interrupt-parent = <&ipic>;
> + interrupts = <0x47 8>;
> + cell-index = <0>;
> + dma-channel@0 {
> + compatible = "fsl,mpc8349-dma-channel";
> + reg = <0 0x80>;
> + };
> + dma-channel@80 {
> + compatible = "fsl,mpc8349-dma-channel";
> + reg = <0x80 0x80>;
> + };
> + dma-channel@100 {
> + compatible = "fsl,mpc8349-dma-channel";
> + reg = <0x100 0x80>;
> + };
> + dma-channel@180 {
> + compatible = "fsl,mpc8349-dma-channel";
> + reg = <0x180 0x28>;
> + };
According to booting-without-of.txt, the interrupts property should be
repeated in each channel. The driver also needs to be fixed to remember
whether it registered a DMA-block-level interrupt handler already, and
not try to register a channel interrupt.
-Scott
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [patch 1/1] fsldma: the MPC8377MDS board device tree node for fsldma driver
2008-05-14 23:28 ` Scott Wood
@ 2008-05-14 23:36 ` Dan Williams
0 siblings, 0 replies; 5+ messages in thread
From: Dan Williams @ 2008-05-14 23:36 UTC (permalink / raw)
To: Scott Wood
Cc: Nelson, Shannon, linuxppc-dev, paulus, galak, akpm, leoli,
wei.zhang
[adding Li Yang (new fsldma maintainer) to the cc]
On Wed, 2008-05-14 at 16:28 -0700, Scott Wood wrote:
> akpm@linux-foundation.org wrote:
> > From: Zhang Wei <wei.zhang@freescale.com>
> >
> > The fsldma driver is tested on MPC8377MDS board. The patch adds fsldma driver
> > support into MPC8377MDS device tree.
> >
> > Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
> > Cc: "Nelson, Shannon" <shannon.nelson@intel.com>
> > Cc: Dan Williams <dan.j.williams@intel.com>
> > Cc: Kumar Gala <galak@gate.crashing.org>
> > Cc: Paul Mackerras <paulus@samba.org>
> > Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> > Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> > ---
> >
> > arch/powerpc/boot/dts/mpc8377_mds.dts | 27 ++++++++++++++++++++++++
> > 1 file changed, 27 insertions(+)
> >
> > diff -puN arch/powerpc/boot/dts/mpc8377_mds.dts~fsldma-the-mpc8377mds-board-device-tree-node-for-fsldma-driver arch/powerpc/boot/dts/mpc8377_mds.dts
> > --- a/arch/powerpc/boot/dts/mpc8377_mds.dts~fsldma-the-mpc8377mds-board-device-tree-node-for-fsldma-driver
> > +++ a/arch/powerpc/boot/dts/mpc8377_mds.dts
> > @@ -295,6 +295,33 @@
> > };
> > };
> >
> > + dma@82a8 {
> > + #address-cells = <1>;
> > + #size-cells = <1>;
> > + compatible = "fsl,mpc8349-dma";
> > + reg = <0x82a8 4>;
> > + ranges = <0 0x8100 0x1a8>;
> > + interrupt-parent = <&ipic>;
> > + interrupts = <0x47 8>;
> > + cell-index = <0>;
> > + dma-channel@0 {
> > + compatible = "fsl,mpc8349-dma-channel";
> > + reg = <0 0x80>;
> > + };
> > + dma-channel@80 {
> > + compatible = "fsl,mpc8349-dma-channel";
> > + reg = <0x80 0x80>;
> > + };
> > + dma-channel@100 {
> > + compatible = "fsl,mpc8349-dma-channel";
> > + reg = <0x100 0x80>;
> > + };
> > + dma-channel@180 {
> > + compatible = "fsl,mpc8349-dma-channel";
> > + reg = <0x180 0x28>;
> > + };
>
> According to booting-without-of.txt, the interrupts property should be
> repeated in each channel. The driver also needs to be fixed to remember
> whether it registered a DMA-block-level interrupt handler already, and
> not try to register a channel interrupt.
>
> -Scott
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* [patch 1/1] fsldma: the MPC8377MDS board device tree node for fsldma driver
@ 2008-06-09 23:29 akpm
2008-06-10 5:16 ` Kumar Gala
0 siblings, 1 reply; 5+ messages in thread
From: akpm @ 2008-06-09 23:29 UTC (permalink / raw)
To: paulus
Cc: shannon.nelson, linuxppc-dev, scottwood, galak, akpm, leoli,
dan.j.williams, wei.zhang
From: Zhang Wei <wei.zhang@freescale.com>
The fsldma driver is tested on MPC8377MDS board. The patch adds fsldma driver
support into MPC8377MDS device tree.
Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
Cc: "Nelson, Shannon" <shannon.nelson@intel.com>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Kumar Gala <galak@gate.crashing.org>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
Cc: Scott Wood <scottwood@freescale.com>
Cc: Li Yang <leoli@freescale.com>
On Wed, 14 May 2008 18:28:08 -0500
Scott Wood <scottwood@freescale.com> wrote:
> akpm@linux-foundation.org wrote:
> > From: Zhang Wei <wei.zhang@freescale.com>
> >
> According to booting-without-of.txt, the interrupts property should be
> repeated in each channel. The driver also needs to be fixed to remember
> whether it registered a DMA-block-level interrupt handler already, and
> not try to register a channel interrupt.
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
---
arch/powerpc/boot/dts/mpc8377_mds.dts | 27 ++++++++++++++++++++++++
1 file changed, 27 insertions(+)
diff -puN arch/powerpc/boot/dts/mpc8377_mds.dts~fsldma-the-mpc8377mds-board-device-tree-node-for-fsldma-driver arch/powerpc/boot/dts/mpc8377_mds.dts
--- a/arch/powerpc/boot/dts/mpc8377_mds.dts~fsldma-the-mpc8377mds-board-device-tree-node-for-fsldma-driver
+++ a/arch/powerpc/boot/dts/mpc8377_mds.dts
@@ -303,6 +303,33 @@
};
};
+ dma@82a8 {
+ #address-cells = <1>;
+ #size-cells = <1>;
+ compatible = "fsl,mpc8349-dma";
+ reg = <0x82a8 4>;
+ ranges = <0 0x8100 0x1a8>;
+ interrupt-parent = <&ipic>;
+ interrupts = <0x47 8>;
+ cell-index = <0>;
+ dma-channel@0 {
+ compatible = "fsl,mpc8349-dma-channel";
+ reg = <0 0x80>;
+ };
+ dma-channel@80 {
+ compatible = "fsl,mpc8349-dma-channel";
+ reg = <0x80 0x80>;
+ };
+ dma-channel@100 {
+ compatible = "fsl,mpc8349-dma-channel";
+ reg = <0x100 0x80>;
+ };
+ dma-channel@180 {
+ compatible = "fsl,mpc8349-dma-channel";
+ reg = <0x180 0x28>;
+ };
+ };
+
/* IPIC
* interrupts cell = <intr #, sense>
* sense values match linux IORESOURCE_IRQ_* defines:
_
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [patch 1/1] fsldma: the MPC8377MDS board device tree node for fsldma driver
2008-06-09 23:29 akpm
@ 2008-06-10 5:16 ` Kumar Gala
0 siblings, 0 replies; 5+ messages in thread
From: Kumar Gala @ 2008-06-10 5:16 UTC (permalink / raw)
To: akpm
Cc: shannon.nelson, linuxppc-dev, paulus, scottwood, galak,
dan.j.williams, leoli, wei.zhang
On Jun 9, 2008, at 6:29 PM, akpm@linux-foundation.org wrote:
> From: Zhang Wei <wei.zhang@freescale.com>
>
> The fsldma driver is tested on MPC8377MDS board. The patch adds
> fsldma driver
> support into MPC8377MDS device tree.
>
> Signed-off-by: Zhang Wei <wei.zhang@freescale.com>
> Cc: "Nelson, Shannon" <shannon.nelson@intel.com>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Kumar Gala <galak@gate.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Scott Wood <scottwood@freescale.com>
> Cc: Li Yang <leoli@freescale.com>
>
> On Wed, 14 May 2008 18:28:08 -0500
> Scott Wood <scottwood@freescale.com> wrote:
>
>
>> akpm@linux-foundation.org wrote:
>>> From: Zhang Wei <wei.zhang@freescale.com>
>>>
>> According to booting-without-of.txt, the interrupts property should
>> be
>> repeated in each channel. The driver also needs to be fixed to
>> remember
>> whether it registered a DMA-block-level interrupt handler already,
>> and
>> not try to register a channel interrupt.
>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
>
> arch/powerpc/boot/dts/mpc8377_mds.dts | 27 ++++++++++++++++++++++++
> 1 file changed, 27 insertions(+)
This is already in Linus's tree as commit
3f346935f4f7141b0253ab0d8dfefb6e20ad08c3
- k
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-06-10 5:16 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-05-14 23:17 [patch 1/1] fsldma: the MPC8377MDS board device tree node for fsldma driver akpm
2008-05-14 23:28 ` Scott Wood
2008-05-14 23:36 ` Dan Williams
-- strict thread matches above, loose matches on Subject: below --
2008-06-09 23:29 akpm
2008-06-10 5:16 ` Kumar Gala
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).