From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Ellerman <michael@ellerman.id.au>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 1/2] Add irq_free_host() to free an irq_host
Date: Wed, 14 May 2008 23:55:12 -0700 [thread overview]
Message-ID: <1210834512.8297.87.camel@pasglop> (raw)
In-Reply-To: <3c91644d7ab701f99ec7f621fc5c16d23e75c71a.1210220561.git.michael@ellerman.id.au>
On Thu, 2008-05-08 at 14:23 +1000, Michael Ellerman wrote:
> +void irq_free_host(struct irq_host *host)
> +{
> + /* If it's still very early in boot we can't free, oh well. */
> + if (mem_init_done)
> + kfree(host);
> +}
Hrm... that means that a host that was allocated before mem_init_done
and freed later will call kfree on memory obtained from bootmem... no
good.
In which case do we need to free and irq host other than failure in
irq_alloc_host ?
Cheers,
Ben.
next prev parent reply other threads:[~2008-05-15 6:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-08 4:23 [PATCH 1/2] Add irq_free_host() to free an irq_host Michael Ellerman
2008-05-08 4:23 ` [PATCH 2/2] Fix irq_alloc_host() reference counting and callers Michael Ellerman
2008-05-13 10:58 ` Paul Mackerras
2008-05-13 11:49 ` Michael Ellerman
2008-05-15 6:55 ` Benjamin Herrenschmidt [this message]
2008-05-15 7:00 ` [PATCH 1/2] Add irq_free_host() to free an irq_host Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210834512.8297.87.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).