From: Remi Machet <rmachet@slac.stanford.edu>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: Linux PPC <linuxppc-dev@ozlabs.org>, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 3/5] powerpc: C2K board driver
Date: Fri, 16 May 2008 09:01:32 -0700 [thread overview]
Message-ID: <1210953692.13992.28.camel@pcds-ts102.slac.stanford.edu> (raw)
In-Reply-To: <20080516144645.490114f6.sfr@canb.auug.org.au>
On Fri, 2008-05-16 at 14:46 +1000, Stephen Rothwell wrote:
> Hi Remi,
>
> On Thu, 15 May 2008 17:24:28 -0700 Remi Machet <rmachet@slac.stanford.edu> wrote:
> >
> > +#include <linux/stddef.h>
> > +#include <linux/kernel.h>
> > +#include <linux/delay.h>
> > +#include <linux/interrupt.h>
> > +#include <linux/seq_file.h>
> > +
> > +#include <asm/machdep.h>
> > +#include <asm/prom.h>
> > +#include <asm/system.h>
> > +#include <linux/time.h>
> > +#include <asm/time.h>
> > +#include <linux/kexec.h>
>
> Normally we don'y mix linux/ and asm/ includes (put all the linux ones at
> the top).
>
> You need to include <linux/of.h> because you use the device tree accessor
> functions.
>
Sorry, I made the mistake when correcting a few checkpatch.pl warnings.
I will fix that and re-submit.
Thanks,
Remi
prev parent reply other threads:[~2008-05-16 16:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-16 0:24 [PATCH 3/5] powerpc: C2K board driver Remi Machet
2008-05-16 4:46 ` Stephen Rothwell
2008-05-16 16:01 ` Remi Machet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1210953692.13992.28.camel@pcds-ts102.slac.stanford.edu \
--to=rmachet@slac.stanford.edu \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).