linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Nate Case <ncase@xes-inc.com>
To: Sebastian Siewior <bigeasy@linutronix.de>
Cc: linuxppc-dev <linuxppc-dev@ozlabs.org>,
	Greg Kroah-Hartman <gregkh@suse.de>,
	linux-usb@vger.kernel.org
Subject: [PATCH 0/2] USB: isp1760: Fixes and support for more hardware configs
Date: Wed, 21 May 2008 16:27:50 -0500	[thread overview]
Message-ID: <1211405270.13845.626.camel@localhost.localdomain> (raw)

I spent a little time getting the new isp1760 driver to work on my ppc64
board with an ISP1761.  There were two main problems I encountered:

  - Driver wrote to the PORT 1 control register which is actually
    the OTG control register on the ISP1761.  This needs to be skipped
    on ISP1761 until we have proper OTG support.

  - Driver assumed 32-bit data bus mode.  You have to jump through
    a couple small hoops to get 16-bit mode to work, including some
    changes to the scratch register test.  I also had to re-order some
    of the steps to occur _after_ setting HW MODE control.

The first patch is a minor fix.  The second patch takes care of the
above issues and also adds support for the other bits in HW MODE control
that might vary from board to board.

Sebastian: I tried to be careful to minimize functional changes for your
case (isp1760, 32-bit mode), so things should work the same for you with
these patches applied.  However, I only have an ISP1761 to test with so
I'd appreciate it if you could test with your board.

I'm CCing linuxppc-dev in case there's any feedback on the OF device
tree property usage in patch 2/2.

-- 
Nate Case <ncase@xes-inc.com>

                 reply	other threads:[~2008-05-21 21:28 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1211405270.13845.626.camel@localhost.localdomain \
    --to=ncase@xes-inc.com \
    --cc=bigeasy@linutronix.de \
    --cc=gregkh@suse.de \
    --cc=linux-usb@vger.kernel.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).