[PATCH 1/2] USB: isp1760: Assign resource fields before adding hcd

[PATCH 1/2] USB: isp1760: Assign resource fields before adding hcd

[Nate Case]

This fixes the bogus "io mem 0x00000000" message printed
during driver init due to hcd->rsrc_start being assigned after
the call to usb_add_hcd().

Signed-off-by: Nate Case <ncase@xes-inc.com>
---
 drivers/usb/host/isp1760-hcd.c |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/usb/host/isp1760-hcd.c b/drivers/usb/host/isp1760-hcd.c
index c9cec87..65aa5ec 100644
--- a/drivers/usb/host/isp1760-hcd.c
+++ b/drivers/usb/host/isp1760-hcd.c
@@ -2207,14 +2207,14 @@ struct usb_hcd *isp1760_register(u64 res_start, u64 res_len, int irq,
 		goto err_put;
 	}
 
-	ret = usb_add_hcd(hcd, irq, irqflags);
-	if (ret)
-		goto err_unmap;
-
 	hcd->irq = irq;
 	hcd->rsrc_start = res_start;
 	hcd->rsrc_len = res_len;
 
+	ret = usb_add_hcd(hcd, irq, irqflags);
+	if (ret)
+		goto err_unmap;
+
 	return hcd;
 
 err_unmap:
-- 
1.5.4.4

Re: [PATCH 1/2] USB: isp1760: Assign resource fields before adding hcd

[Sebastian Siewior]

* Nate Case | 2008-05-21 16:28:20 [-0500]:

>This fixes the bogus "io mem 0x00000000" message printed
>during driver init due to hcd->rsrc_start being assigned after
>the call to usb_add_hcd().
>
>Signed-off-by: Nate Case <ncase@xes-inc.com>
I saw this and was wondering why it was correct in other places like
/proc/iomem :)

Acked-by: Sebastian Siewior <bigeasy@linutronix.de>

patch usb-isp1760-assign-resource-fields-before-adding-hcd.patch added to gregkh-2.6 tree

[gregkh]

This is a note to let you know that I've just added the patch titled

     Subject: USB: isp1760: Assign resource fields before adding hcd

to my gregkh-2.6 tree.  Its filename is

     usb-isp1760-assign-resource-fields-before-adding-hcd.patch

This tree can be found at 
    http://www.kernel.org/pub/linux/kernel/people/gregkh/gregkh-2.6/patches/


>From ncase@xes-inc.com  Fri Jun  6 15:07:08 2008
From: Nate Case <ncase@xes-inc.com>
Date: Wed, 21 May 2008 16:28:20 -0500
Subject: USB: isp1760: Assign resource fields before adding hcd
To: Sebastian Siewior <bigeasy@linutronix.de>
Cc: Greg Kroah-Hartman <gregkh@suse.de>, linux-usb@vger.kernel.org, linuxppc-dev <linuxppc-dev@ozlabs.org>
Message-ID: <1211405300.13845.627.camel@localhost.localdomain>


This fixes the bogus "io mem 0x00000000" message printed
during driver init due to hcd->rsrc_start being assigned after
the call to usb_add_hcd().

Signed-off-by: Nate Case <ncase@xes-inc.com>
Acked-by: Sebastian Siewior <bigeasy@linutronix.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>

---
 drivers/usb/host/isp1760-hcd.c |    8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

--- a/drivers/usb/host/isp1760-hcd.c
+++ b/drivers/usb/host/isp1760-hcd.c
@@ -2207,14 +2207,14 @@ struct usb_hcd *isp1760_register(u64 res
 		goto err_put;
 	}
 
-	ret = usb_add_hcd(hcd, irq, irqflags);
-	if (ret)
-		goto err_unmap;
-
 	hcd->irq = irq;
 	hcd->rsrc_start = res_start;
 	hcd->rsrc_len = res_len;
 
+	ret = usb_add_hcd(hcd, irq, irqflags);
+	if (ret)
+		goto err_unmap;
+
 	return hcd;
 
 err_unmap:


Patches currently in gregkh-2.6 which might be from ncase@xes-inc.com are

usb.current/usb-isp1760-assign-resource-fields-before-adding-hcd.patch