From: Michael Ellerman <michael@ellerman.id.au>
To: Medve Emilian <Emilian.Medve@freescale.com>
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org, linuxppc-embedded@ozlabs.org
Subject: RE: [PATCH] [POWERPC] Fix return value check logic
Date: Sat, 24 May 2008 00:52:05 +1000 [thread overview]
Message-ID: <1211554325.16348.8.camel@localhost> (raw)
In-Reply-To: <598D5675D34BE349929AF5EDE9B03E2701F48298@az33exm24.fsl.freescale.net>
[-- Attachment #1: Type: text/plain, Size: 744 bytes --]
On Fri, 2008-05-23 at 07:39 -0700, Medve Emilian wrote:
> Hello Michael,
>
>
> > > That won't work if CONFIG_DEBUG_FS is not defined, because in
> > > that case
> > > debugfs_create_file() returns -ENODEV.
> >
> > Will respin.
>
> At a second glance in arch/powerpc/Kconfig.debug, VIRQ_DEBUG depends on
> DEBUG_FS so I think that the patch should work as is.
You're right, thanks for checking. In that case:
Acked-by: Michael Ellerman <michael@ellerman.id.au>
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2008-05-23 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-22 19:49 [PATCH] [POWERPC] Fix return value check logic Emil Medve
2008-05-23 1:13 ` Michael Ellerman
2008-05-23 14:19 ` Medve Emilian
2008-05-23 14:39 ` Medve Emilian
2008-05-23 14:52 ` Michael Ellerman [this message]
2008-06-15 16:48 ` Medve Emilian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1211554325.16348.8.camel@localhost \
--to=michael@ellerman.id.au \
--cc=Emilian.Medve@freescale.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=linuxppc-embedded@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).