[PATCH] i2c-ibm_iic: Enable driver for all PPC4xx variants in arch/powerpc

[PATCH] i2c-ibm_iic: Enable driver for all PPC4xx variants in arch/powerpc

[Stefan Roese]

This patch enables the IBM I2C driver for all PPC4xx variants by adding
"ibm,iic" to the compatible list. This way all currently available
arch/powerpc 4xx ports can make use of this driver without any changes.
Additionally all "other" compatible entries are removed since they are
not needed anymore.

Currently all 4xx PPC's have the same compatible I2C macro. If at some
time an incompatibility is detected we can take care of this with an
additional property.

Signed-off-by: Stefan Roese <sr@denx.de>
---
 drivers/i2c/busses/i2c-ibm_iic.c |    6 +-----
 1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/drivers/i2c/busses/i2c-ibm_iic.c b/drivers/i2c/busses/i2c-ibm_iic.c
index 3a364a7..ed73801 100644
--- a/drivers/i2c/busses/i2c-ibm_iic.c
+++ b/drivers/i2c/busses/i2c-ibm_iic.c
@@ -807,11 +807,7 @@ static int __devexit iic_remove(struct of_device *ofdev)
 }
 
 static const struct of_device_id ibm_iic_match[] = {
-	{ .compatible = "ibm,iic-405ex", },
-	{ .compatible = "ibm,iic-405gp", },
-	{ .compatible = "ibm,iic-440gp", },
-	{ .compatible = "ibm,iic-440gpx", },
-	{ .compatible = "ibm,iic-440grx", },
+	{ .compatible = "ibm,iic", },
 	{}
 };
 
-- 
1.5.5.3

Re: [PATCH] i2c-ibm_iic: Enable driver for all PPC4xx variants in arch/powerpc

[Josh Boyer]

On Thu,  5 Jun 2008 10:10:53 +0200
Stefan Roese <sr@denx.de> wrote:

> This patch enables the IBM I2C driver for all PPC4xx variants by adding
> "ibm,iic" to the compatible list. This way all currently available
> arch/powerpc 4xx ports can make use of this driver without any changes.
> Additionally all "other" compatible entries are removed since they are
> not needed anymore.
> 
> Currently all 4xx PPC's have the same compatible I2C macro. If at some
> time an incompatibility is detected we can take care of this with an
> additional property.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>

Acked-by: Josh Boyer <jwboyer@linux.vnet.ibm.com>

josh
> ---
>  drivers/i2c/busses/i2c-ibm_iic.c |    6 +-----
>  1 files changed, 1 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-ibm_iic.c b/drivers/i2c/busses/i2c-ibm_iic.c
> index 3a364a7..ed73801 100644
> --- a/drivers/i2c/busses/i2c-ibm_iic.c
> +++ b/drivers/i2c/busses/i2c-ibm_iic.c
> @@ -807,11 +807,7 @@ static int __devexit iic_remove(struct of_device *ofdev)
>  }
>  
>  static const struct of_device_id ibm_iic_match[] = {
> -	{ .compatible = "ibm,iic-405ex", },
> -	{ .compatible = "ibm,iic-405gp", },
> -	{ .compatible = "ibm,iic-440gp", },
> -	{ .compatible = "ibm,iic-440gpx", },
> -	{ .compatible = "ibm,iic-440grx", },
> +	{ .compatible = "ibm,iic", },
>  	{}
>  };
>  

Re: [PATCH] i2c-ibm_iic: Enable driver for all PPC4xx variants in arch/powerpc

[Jean Delvare]

Hi Stefan,

On Thu,  5 Jun 2008 10:10:53 +0200, Stefan Roese wrote:
> This patch enables the IBM I2C driver for all PPC4xx variants by adding
> "ibm,iic" to the compatible list. This way all currently available
> arch/powerpc 4xx ports can make use of this driver without any changes.
> Additionally all "other" compatible entries are removed since they are
> not needed anymore.
> 
> Currently all 4xx PPC's have the same compatible I2C macro. If at some
> time an incompatibility is detected we can take care of this with an
> additional property.
> 
> Signed-off-by: Stefan Roese <sr@denx.de>
> ---
>  drivers/i2c/busses/i2c-ibm_iic.c |    6 +-----
>  1 files changed, 1 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/i2c/busses/i2c-ibm_iic.c b/drivers/i2c/busses/i2c-ibm_iic.c
> index 3a364a7..ed73801 100644
> --- a/drivers/i2c/busses/i2c-ibm_iic.c
> +++ b/drivers/i2c/busses/i2c-ibm_iic.c
> @@ -807,11 +807,7 @@ static int __devexit iic_remove(struct of_device *ofdev)
>  }
>  
>  static const struct of_device_id ibm_iic_match[] = {
> -	{ .compatible = "ibm,iic-405ex", },
> -	{ .compatible = "ibm,iic-405gp", },
> -	{ .compatible = "ibm,iic-440gp", },
> -	{ .compatible = "ibm,iic-440gpx", },
> -	{ .compatible = "ibm,iic-440grx", },
> +	{ .compatible = "ibm,iic", },
>  	{}
>  };
>  

OK, I can take this in my tree, unless it depends on arch-specific
patches which have not hit mainline yet. I guess this is 2.6.27
material?

-- 
Jean Delvare

Re: [PATCH] i2c-ibm_iic: Enable driver for all PPC4xx variants in arch/powerpc

[Stefan Roese]

Hi Jean,

On Sunday 08 June 2008, Jean Delvare wrote:
> > This patch enables the IBM I2C driver for all PPC4xx variants by adding
> > "ibm,iic" to the compatible list. This way all currently available
> > arch/powerpc 4xx ports can make use of this driver without any changes.
> > Additionally all "other" compatible entries are removed since they are
> > not needed anymore.
> >
> > Currently all 4xx PPC's have the same compatible I2C macro. If at some
> > time an incompatibility is detected we can take care of this with an
> > additional property.
> >
> > Signed-off-by: Stefan Roese <sr@denx.de>
> > ---
> >  drivers/i2c/busses/i2c-ibm_iic.c |    6 +-----
> >  1 files changed, 1 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/i2c/busses/i2c-ibm_iic.c
> > b/drivers/i2c/busses/i2c-ibm_iic.c index 3a364a7..ed73801 100644
> > --- a/drivers/i2c/busses/i2c-ibm_iic.c
> > +++ b/drivers/i2c/busses/i2c-ibm_iic.c
> > @@ -807,11 +807,7 @@ static int __devexit iic_remove(struct of_device
> > *ofdev) }
> >
> >  static const struct of_device_id ibm_iic_match[] = {
> > -	{ .compatible = "ibm,iic-405ex", },
> > -	{ .compatible = "ibm,iic-405gp", },
> > -	{ .compatible = "ibm,iic-440gp", },
> > -	{ .compatible = "ibm,iic-440gpx", },
> > -	{ .compatible = "ibm,iic-440grx", },
> > +	{ .compatible = "ibm,iic", },
> >  	{}
> >  };
>
> OK, I can take this in my tree, unless it depends on arch-specific
> patches which have not hit mainline yet.

No, this doesn't depend on other pathes.

> I guess this is 2.6.27 
> material?

Yes. No real hurry here.

Thanks.

Best regards,
Stefan