Re: Linux 2.6.26-rc5

Re: Linux 2.6.26-rc5

[Olaf Hering]

On Wed, Jun 04, Linus Torvalds wrote:

> Another week, another batch of mostly pretty small fixes. Hopefully the 
> regression list is shrinking, and we've fixed at least a couple of the 
> oopses on Arjan's list.

SATA on a dualcore G5 is broken, it happend between
c3b25b32e8bef526cca748e1ba023c6bdd705a99..53c8ba95402be65d412a806cda3430f0e72cd107

irq 18: nobody cared (try booting with the "irqpoll" option)
Disabling IRQ #18


ctrl alt del on the USB keyboard does not trigger a reboot.
Sometimes the cursor stops blinking, sometimes just nothing happens
after ctrl alt del.


Does 53c8ba95402be65d412a806cda3430f0e72cd107 work for others on G5?

Re: Linux 2.6.26-rc5 (G5 SATA broken)

[Hugh Dickins]

On Thu, 5 Jun 2008, Olaf Hering wrote:
> On Wed, Jun 04, Linus Torvalds wrote:
> 
> > Another week, another batch of mostly pretty small fixes. Hopefully the 
> > regression list is shrinking, and we've fixed at least a couple of the 
> > oopses on Arjan's list.
> 
> SATA on a dualcore G5 is broken, it happend between
> c3b25b32e8bef526cca748e1ba023c6bdd705a99..53c8ba95402be65d412a806cda3430f0e72cd107
> 
> irq 18: nobody cared (try booting with the "irqpoll" option)
> Disabling IRQ #18
> 
> ctrl alt del on the USB keyboard does not trigger a reboot.
> Sometimes the cursor stops blinking, sometimes just nothing happens
> after ctrl alt del.
> 
> Does 53c8ba95402be65d412a806cda3430f0e72cd107 work for others on G5?

I've been bisecting that on Quad G5 (sata_svw): irq 18: nobody cared ...,
then later endless ata1.00: exception..., blah blah, ata1: EH complete.
It comes down to:

commit a57c1bade5a0ee5cd8b74502db9cbebb7f5780b2
Author: Alan Cox <alan@lxorguk.ukuu.org.uk>
Date:   Thu May 29 22:10:58 2008 +0100
libata-sff: Fix oops reported in kerneloops.org for pnp devices with no ctl

And the patch I'm finding successful is below: I won't sign it off,
for all I know it's reverting part of what Alan is trying to achieve;
but I expect it'll help towards the right fix.

Hugh

--- 2.6.26-rc5/drivers/ata/libata-sff.c	2008-06-05 07:18:07.000000000 +0100
+++ linux/drivers/ata/libata-sff.c	2008-06-05 12:42:39.000000000 +0100
@@ -278,7 +278,7 @@ static u8 ata_sff_irq_status(struct ata_
 		    	return status;
 	}
 	/* Clear INTRQ latch */
-	status = ata_sff_check_status(ap);
+	status = ap->ops->sff_check_status(ap);
 	return status;
 }
 

Re: Linux 2.6.26-rc5 (G5 SATA broken)

[Alan Cox]

> And the patch I'm finding successful is below: I won't sign it off,
> for all I know it's reverting part of what Alan is trying to achieve;
> but I expect it'll help towards the right fix.

Its the right fix 

	ata_sff_check_altstatus() is a routine which does the altstatus
check and may or may not call the helper

	ata_sff_check_status() is a default method for ap->ops->

This lunatic naming leads to mistakes 8(

[PATCH] libata: fix G5 SATA broken on -rc5

[Hugh Dickins]

Fix G5 SATA irq 18: nobody cared, reported on -rc5 by Olaf Hering:
fixlet to a57c1bade5a0ee5cd8b74502db9cbebb7f5780b2 libata-sff:
Fix oops reported in kerneloops.org for pnp devices with no ctl
    
Signed-off-by: Hugh Dickins <hugh@veritas.com>
Acked-by: Alan Cox <alan@lxorguk.ukuu.org.uk>
---

 drivers/ata/libata-sff.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- 2.6.26-rc5/drivers/ata/libata-sff.c	2008-06-05 07:18:07.000000000 +0100
+++ linux/drivers/ata/libata-sff.c	2008-06-05 12:42:39.000000000 +0100
@@ -278,7 +278,7 @@ static u8 ata_sff_irq_status(struct ata_
 		    	return status;
 	}
 	/* Clear INTRQ latch */
-	status = ata_sff_check_status(ap);
+	status = ap->ops->sff_check_status(ap);
 	return status;
 }
 

Re: [PATCH] libata: fix G5 SATA broken on -rc5

[Olaf Hering]

On Thu, Jun 05, Hugh Dickins wrote:

> Fix G5 SATA irq 18: nobody cared, reported on -rc5 by Olaf Hering:
> fixlet to a57c1bade5a0ee5cd8b74502db9cbebb7f5780b2 libata-sff:
> Fix oops reported in kerneloops.org for pnp devices with no ctl
>     
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
> Acked-by: Alan Cox <alan@lxorguk.ukuu.org.uk>


Tested-by: Olaf Hering <olaf@aepfle.de>

Re: Linux 2.6.26-rc5 (G5 SATA broken)

[Benjamin Herrenschmidt]

> I've been bisecting that on Quad G5 (sata_svw): irq 18: nobody cared ...,
> then later endless ata1.00: exception..., blah blah, ata1: EH complete.
> It comes down to:

Thanks for finding that !

/me likes when he wakes up in the morning to find a G5 bug ... and the
fix in the same thread :-)

Cheers,
Ben.

Re: Linux 2.6.26-rc5

[Alan Cox]

On Thu, 5 Jun 2008 13:24:36 +0200
Olaf Hering <olaf@aepfle.de> wrote:

> On Wed, Jun 04, Linus Torvalds wrote:
> 
> > Another week, another batch of mostly pretty small fixes. Hopefully the 
> > regression list is shrinking, and we've fixed at least a couple of the 
> > oopses on Arjan's list.
> 
> SATA on a dualcore G5 is broken, it happend between

See the patch I just posted to Nick/Jeff should fix it. I always said
ata_sff_check_status() was asking for trouble as a name and neither I nor
Jeff nor Linus noticed the bug...