From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: akpm@linux-foundation.org
Cc: linuxppc-dev@ozlabs.org, paulus@samba.org
Subject: Re: [patch 5/5] arch/powerpc/platforms/pseries/eeh_driver.c: fix warning
Date: Tue, 10 Jun 2008 09:47:02 +1000 [thread overview]
Message-ID: <1213055222.25745.16.camel@pasglop> (raw)
In-Reply-To: <200806092326.m59NQA9c014230@imap1.linux-foundation.org>
On Mon, 2008-06-09 at 16:26 -0700, akpm@linux-foundation.org wrote:
> From: Andrew Morton <akpm@linux-foundation.org>
>
> Fix this:
>
> /usr/src/devel/arch/powerpc/platforms/pseries/eeh_driver.c: In function 'print_device_node_tree':
> /usr/src/devel/arch/powerpc/platforms/pseries/eeh_driver.c:55: warning: ISO C90 forbids mixed declarations and code
>
> also make that function look like it's part of Linux. I mean, wtf are you
> guys up to down there??
The EEH code ... oh well. It does need some love...
> [akpm@linux-foundation.org: coding-style fixes]
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
> Cc: Paul Mackerras <paulus@samba.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
next prev parent reply other threads:[~2008-06-09 23:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-09 23:26 [patch 5/5] arch/powerpc/platforms/pseries/eeh_driver.c: fix warning akpm
2008-06-09 23:47 ` Benjamin Herrenschmidt [this message]
2008-06-10 0:00 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213055222.25745.16.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).