From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stefan Roscher <ossrosch@linux.vnet.ibm.com>
Cc: TKLEIN@de.ibm.com, THEMANN@de.ibm.com, fenkes@de.ibm.com,
LKML <linux-kernel@vger.kernel.org>,
OF-EWG <ewg@lists.openfabrics.org>,
LinuxPPC-Dev <linuxppc-dev@ozlabs.org>,
raisch@de.ibm.com, Paul Mackerras <paulus@samba.org>,
general@lists.openfabrics.org
Subject: Re: [PATCH REPOST] IB/ehca: In case of lost interrupts, trigger EOI to reenable interrupts
Date: Thu, 12 Jun 2008 17:23:15 +1000 [thread overview]
Message-ID: <1213255395.14478.28.camel@pasglop> (raw)
In-Reply-To: <200806101644.34693.ossrosch@linux.vnet.ibm.com>
On Tue, 2008-06-10 at 16:44 +0200, Stefan Roscher wrote:
> During corner case testing, we noticed that some versions of ehca
> do not properly transition to interrupt done in special load situations.
> This can be resolved by periodically triggering EOI through H_EOI,
> if eqes are pending.
>
> Signed-off-by: Stefan Roscher <stefan.roscher@de.ibm.com>
This patch is fine with me as long as the FW/HW people can confirm that
calling spurrious EOI's like that will not affect other interrupts.
The side effect of writing 0xff to the xirr should be irrelevant as long as
this is not done from within a HW interrupt handler (timer interrupts or
softirqs are fine).
Due to the already incestuous relationship between HCA and the hypervisor,
I don't mind having the H call directly in the driver.
So as long as the FW/HW people are ok with that workaround, then it has
my ack as well.
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
next prev parent reply other threads:[~2008-06-12 7:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-10 14:44 [PATCH REPOST] IB/ehca: In case of lost interrupts, trigger EOI to reenable interrupts Stefan Roscher
2008-06-10 14:52 ` Roland Dreier
2008-06-10 15:01 ` Stefan Roscher
2008-06-10 16:18 ` Roland Dreier
2008-06-12 8:37 ` Paul Mackerras
2008-06-13 14:39 ` Stefan Roscher
2008-06-12 7:23 ` Benjamin Herrenschmidt [this message]
2008-06-12 9:39 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213255395.14478.28.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=THEMANN@de.ibm.com \
--cc=TKLEIN@de.ibm.com \
--cc=ewg@lists.openfabrics.org \
--cc=fenkes@de.ibm.com \
--cc=general@lists.openfabrics.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=ossrosch@linux.vnet.ibm.com \
--cc=paulus@samba.org \
--cc=raisch@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).