From: Michael Ellerman <michael@ellerman.id.au>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: "linuxppc-dev@ozlabs.org list" <linuxppc-dev@ozlabs.org>,
Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 1/6] Move code patching code into arch/powerpc/lib/code-patching.c
Date: Thu, 19 Jun 2008 16:55:13 +1000 [thread overview]
Message-ID: <1213858514.25483.1.camel@localhost> (raw)
In-Reply-To: <5A31B777-6591-4AE9-BDE5-3B624AED10A4@kernel.crashing.org>
[-- Attachment #1: Type: text/plain, Size: 1856 bytes --]
On Thu, 2008-06-19 at 01:15 -0500, Kumar Gala wrote:
> On May 29, 2008, at 1:20 AM, Michael Ellerman wrote:
>
> > We currently have a few routines for patching code in asm/system.h,
> > because
> > they didn't fit anywhere else. I'd like to clean them up a little
> > and add
> > some more, so first move them into a dedicated C file - they don't
> > need to
> > be inlined.
> >
> > While we're moving the code, drop create_function_call(), it's
> > intended
> > caller never got merged and will be replaced in future with something
> > different.
> >
> > Signed-off-by: Michael Ellerman <michael@ellerman.id.au>
> > ---
> > arch/powerpc/kernel/crash_dump.c | 1 +
> > arch/powerpc/lib/Makefile | 2 +
> > arch/powerpc/lib/code-patching.c | 33 ++++++++++++++++++++
> > arch/powerpc/platforms/86xx/mpc86xx_smp.c | 1 +
> > arch/powerpc/platforms/powermac/smp.c | 1 +
> > include/asm-powerpc/code-patching.h | 25 +++++++++++++++
> > include/asm-powerpc/system.h | 48
> > -----------------------------
> > 7 files changed, 63 insertions(+), 48 deletions(-)
> >
> > diff --git a/arch/powerpc/kernel/crash_dum
>
> what's the state of these patches and getting them into powerpc-next?
I think what I posted is reasonably solid, I've added some more routines
for the stuff I'm working on. I'll repost today or tommorrow.
> I'm looking at some runtime fix ups that I was thinking of basing on
> this code.
What have you got in mind? I'm working on some runtime fixups too :)
cheers
--
Michael Ellerman
OzLabs, IBM Australia Development Lab
wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)
We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]
next prev parent reply other threads:[~2008-06-19 6:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-29 6:20 [PATCH 1/6] Move code patching code into arch/powerpc/lib/code-patching.c Michael Ellerman
2008-05-29 6:20 ` [PATCH 2/6] Allow create_branch() to return errors Michael Ellerman
2008-05-29 6:31 ` Benjamin Herrenschmidt
2008-06-05 3:48 ` Michael Ellerman
2008-05-29 6:20 ` [PATCH 3/6] Make create_branch() return errors if the branch target is too large Michael Ellerman
2008-05-29 6:33 ` Benjamin Herrenschmidt
2008-05-29 6:20 ` [PATCH 4/6] Add ppc_function_entry() which gets the entry point for a function Michael Ellerman
2008-05-29 6:37 ` Benjamin Herrenschmidt
2008-05-29 6:57 ` Michael Ellerman
2008-05-29 6:21 ` [PATCH 5/6] Add tests for the code patching code, and introduce checking functions Michael Ellerman
2008-05-29 6:21 ` [PATCH 6/6] Add PPC_NOP_INSTR, a hash define for the preferred nop instruction Michael Ellerman
2008-05-29 6:30 ` [PATCH 1/6] Move code patching code into arch/powerpc/lib/code-patching.c Benjamin Herrenschmidt
2008-06-19 6:15 ` Kumar Gala
2008-06-19 6:55 ` Michael Ellerman [this message]
2008-06-19 13:23 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1213858514.25483.1.camel@localhost \
--to=michael@ellerman.id.au \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).