From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id E3410DDF08 for ; Thu, 19 Jun 2008 19:33:52 +1000 (EST) Subject: Re: [PATCH 5/9] powerpc: Introduce VSX thread_struct and CONFIG_VSX From: Benjamin Herrenschmidt To: Kumar Gala In-Reply-To: <4D6D9E9A-EE1C-45E5-B493-0249C256B02B@kernel.crashing.org> References: <20080618004734.0B72E70296@localhost.localdomain> <5AEB0769-1394-4924-803D-C40CAF685519@kernel.crashing.org> <14228.1213850120@neuling.org> <26165.1213853871@neuling.org> <29411.1213855280@neuling.org> <4D6D9E9A-EE1C-45E5-B493-0249C256B02B@kernel.crashing.org> Content-Type: text/plain Date: Thu, 19 Jun 2008 19:33:39 +1000 Message-Id: <1213868019.8011.68.camel@pasglop> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org, Michael Neuling , Paul Mackerras Reply-To: benh@kernel.crashing.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2008-06-19 at 01:10 -0500, Kumar Gala wrote: > > I still think using the union makes it is easier to read than what you > > have here. Also, it better reflects the structure of what's being > > stored there. > > I don't think that holds much weight with me. We don't union the > vector128 type to show it also supports float, u16, and u8 types. But this is different. The same registers are either basic FP regs or full VSX regs. I don't see what's wrong with union, it's a nice way to express things. > I stick by the fact that the ONLY place it looks like you access the > union via the .vsr member is for memset or memcpy so you clearly know > if the size should be sizeof(double) or sizeof(vector). > > Also, I can see the case in the future that 'fpr's become What's wrong with the union ? there's nothing ugly about them.. Cheers, Ben.