From: Stefan Roese <sr@denx.de>
To: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org
Cc: Sathya Narayanan <sathyan@teamf1.com>
Subject: [PATCH] ibm_newemac: Fixes kernel crashes when speed of cable connected changes
Date: Mon, 23 Jun 2008 14:54:54 +0200 [thread overview]
Message-ID: <1214225694-25815-1-git-send-email-sr@denx.de> (raw)
From: Sathya Narayanan <sathyan@teamf1.com>
The descriptor pointers were not initialized to NIL values, so it was
poiniting to some random addresses which was completely invalid. This
fix takes care of initializing the descriptor to NIL values and clearing
the valid descriptors on clean ring operation.
Signed-off-by: Sathya Narayanan <sathyan@teamf1.com>
Signed-off-by: Stefan Roese <sr@denx.de>
---
drivers/net/ibm_newemac/core.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
index 5d2108c..6dfc2c9 100644
--- a/drivers/net/ibm_newemac/core.c
+++ b/drivers/net/ibm_newemac/core.c
@@ -1025,7 +1025,7 @@ static void emac_clean_tx_ring(struct emac_instance *dev)
int i;
for (i = 0; i < NUM_TX_BUFF; ++i) {
- if (dev->tx_skb[i]) {
+ if (dev->tx_skb[i] && dev->tx_desc[i].data_ptr) {
dev_kfree_skb(dev->tx_skb[i]);
dev->tx_skb[i] = NULL;
if (dev->tx_desc[i].ctrl & MAL_TX_CTRL_READY)
@@ -2719,6 +2719,10 @@ static int __devinit emac_probe(struct of_device *ofdev,
/* Clean rings */
memset(dev->tx_desc, 0, NUM_TX_BUFF * sizeof(struct mal_descriptor));
memset(dev->rx_desc, 0, NUM_RX_BUFF * sizeof(struct mal_descriptor));
+ for (i = 0; i <= NUM_TX_BUFF; i++)
+ dev->tx_skb[i] = NULL;
+ for (i = 0; i <= NUM_RX_BUFF; i++)
+ dev->rx_skb[i] = NULL;
/* Attach to ZMII, if needed */
if (emac_has_feature(dev, EMAC_FTR_HAS_ZMII) &&
--
1.5.6
next reply other threads:[~2008-06-23 12:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 12:54 Stefan Roese [this message]
2008-06-23 23:20 ` [PATCH] ibm_newemac: Fixes kernel crashes when speed of cable connected changes Benjamin Herrenschmidt
2008-06-27 6:54 ` SathyaNarayanan
2008-06-27 8:54 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214225694-25815-1-git-send-email-sr@denx.de \
--to=sr@denx.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=sathyan@teamf1.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).