From: Stefan Roese <sr@denx.de>
To: linuxppc-dev@ozlabs.org, netdev@vger.kernel.org
Cc: Sathya Narayanan <sathyan@teamf1.com>
Subject: [PATCH] ibm_newemac: Fixes entry of short packets
Date: Mon, 23 Jun 2008 14:55:05 +0200 [thread overview]
Message-ID: <1214225705-25850-1-git-send-email-sr@denx.de> (raw)
From: Sathya Narayanan <sathyan@teamf1.com>
Short packets has to be discarded by the driver. So this patch addresses the
issue of discarding the short packets of size lesser then ethernet header
size.
Signed-off-by: Sathya Narayanan <sathyan@teamf1.com>
Signed-off-by: Stefan Roese <sr@denx.de>
---
drivers/net/ibm_newemac/core.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/net/ibm_newemac/core.c b/drivers/net/ibm_newemac/core.c
index 6dfc2c9..aa407b2 100644
--- a/drivers/net/ibm_newemac/core.c
+++ b/drivers/net/ibm_newemac/core.c
@@ -1652,6 +1652,13 @@ static int emac_poll_rx(void *param, int budget)
skb_put(skb, len);
push_packet:
+ if (skb->len < ETH_HLEN) {
+ dev_kfree_skb(skb);
+ printk(KERN_WARNING "%s: short packets dropped\n",
+ dev->ndev->name);
+ ++dev->estats.rx_dropped_stack;
+ goto next;
+ }
skb->dev = dev->ndev;
skb->protocol = eth_type_trans(skb, dev->ndev);
emac_rx_csum(dev, skb, ctrl);
--
1.5.6
next reply other threads:[~2008-06-23 12:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 12:55 Stefan Roese [this message]
2008-06-23 23:20 ` [PATCH] ibm_newemac: Fixes entry of short packets Benjamin Herrenschmidt
2008-06-27 6:36 ` SathyaNarayanan
2008-06-27 8:58 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214225705-25850-1-git-send-email-sr@denx.de \
--to=sr@denx.de \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=sathyan@teamf1.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).