From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Timur Tabi <timur@freescale.com>
Cc: linuxppc-dev@ozlabs.org, sr@denx.de
Subject: Re: [PATCH] powerpc: add of_find_next_property and of_get_aliased_index
Date: Thu, 26 Jun 2008 20:57:44 +1000 [thread overview]
Message-ID: <1214477864.8011.466.camel@pasglop> (raw)
In-Reply-To: <1214424332-18496-1-git-send-email-timur@freescale.com>
> +struct property *of_find_next_property(const struct device_node *np,
> + struct property *prev)
> +{
> + struct property *next;
> +
> + if (!np)
> + return NULL;
> +
> + read_lock(&devtree_lock);
> + next = prev ? prev->next : np->properties;
> + read_unlock(&devtree_lock);
> +
> + return next;
> +}
Unfortunately, this isn't race free vs. removal or addition of
properties. This is fine with the intended usage (ie. retreiving
aliases) but at least that should be explained in a comment.
Cheers,
Ben.
prev parent reply other threads:[~2008-06-26 11:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-25 20:05 [PATCH] powerpc: add of_find_next_property and of_get_aliased_index Timur Tabi
2008-06-25 20:22 ` Segher Boessenkool
2008-06-25 20:27 ` Timur Tabi
2008-06-25 23:35 ` Segher Boessenkool
2008-06-26 15:12 ` Timur Tabi
2008-06-26 15:51 ` Stefan Roese
2008-06-26 15:55 ` Timur Tabi
2008-06-26 18:27 ` [PATCH] powerpc: add of_find_next_property andof_get_aliased_index Sean MacLennan
2008-06-26 18:29 ` Timur Tabi
2008-06-26 18:41 ` Stefan Roese
2008-06-27 1:30 ` David Gibson
2008-07-03 13:33 ` Josh Boyer
2008-07-03 13:43 ` Stefan Roese
2008-06-25 23:51 ` [PATCH] powerpc: add of_find_next_property and of_get_aliased_index Josh Boyer
2008-06-26 10:57 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214477864.8011.466.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sr@denx.de \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).