From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: SathyaNarayanan <sathyan@teamf1.com>
Cc: linuxppc-dev@ozlabs.org, Stefan Roese <sr@denx.de>,
netdev@vger.kernel.org
Subject: Re: [PATCH] ibm_newemac: Fixes entry of short packets
Date: Fri, 27 Jun 2008 18:58:34 +1000 [thread overview]
Message-ID: <1214557114.8011.539.camel@pasglop> (raw)
In-Reply-To: <1946a170806262336y4aa3621at16520fc546bbe4b1@mail.gmail.com>
>
>
> Actually , short packets are not allowed to flow through the higher
> layers, If any of the layer tried to use the extra room available may
> hit wit crash .
> Since it is a invalid packet it has to be dropped and freed in driver.
> Actually if you see in code, the other invalid packets are also
> handelled similar.
My point is they should not. The rx skb should be kept in the ring for
further rx (ie, the data ignored and re-use the skb). A bit like we do
when we decide the packet is small enough to be copied to a new skb.
Ie. Move you test above the threshold test and recycle the skb.
We need to fix the usage of the dma operations in this driver anyway
and this will make it easier as we'll be able to avoid re-mapping an
skb we just recycle. (the current driver never unmaps which means it
can't be used with an iommu, which is a problem on some cell based
platforms).
Ben.
prev parent reply other threads:[~2008-06-27 8:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-23 12:55 [PATCH] ibm_newemac: Fixes entry of short packets Stefan Roese
2008-06-23 23:20 ` Benjamin Herrenschmidt
2008-06-27 6:36 ` SathyaNarayanan
2008-06-27 8:58 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214557114.8011.539.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=netdev@vger.kernel.org \
--cc=sathyan@teamf1.com \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).