* [POWERPC] mpc7448hpc2.dts: remove chosen node from dts
@ 2008-06-30 3:03 Chunbo Luo
2008-06-30 16:22 ` Segher Boessenkool
0 siblings, 1 reply; 4+ messages in thread
From: Chunbo Luo @ 2008-06-30 3:03 UTC (permalink / raw)
To: linuxppc-dev
=EF=BB=BFModern versions of u-boot create a chosen node automatically. So =
if
we set the chosen node in the dts file, there will be 2 chosen nodes
passed in to the kernel, and the kernel command line will be taken from
the wrong node. So, remove the extra chosen node from the dts file.
=EF=BB=BFSigned-off-by: Chunbo Luo <chunbo.luo@windriver.com>
---
arch/powerpc/boot/dts/mpc7448hpc2.dts | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/boot/dts/mpc7448hpc2.dts
b/arch/powerpc/boot/dts/mpc7448hpc2.dts
index 4936349..d74727f 100644
--- a/arch/powerpc/boot/dts/mpc7448hpc2.dts
+++ b/arch/powerpc/boot/dts/mpc7448hpc2.dts
@@ -186,8 +186,5 @@
};
};
};
- chosen {
- linux,stdout-path =3D "/tsi108@c0000000/serial@7808";
- };
=20
};
---
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [POWERPC] mpc7448hpc2.dts: remove chosen node from dts
@ 2008-06-30 4:37 Chunbo Luo
0 siblings, 0 replies; 4+ messages in thread
From: Chunbo Luo @ 2008-06-30 4:37 UTC (permalink / raw)
To: linuxppc-dev
=EF=BB=BF=EF=BB=BFModern versions of u-boot create a chosen node automatica=
lly. So if
we set the chosen node in the dts file, there will be 2 chosen nodes
passed in to the kernel, and the kernel command line will be taken from
the wrong node. So, remove the extra chosen node from the dts file.
=EF=BB=BFSigned-off-by: Chunbo Luo <chunbo.luo@windriver.com>
---
arch/powerpc/boot/dts/mpc7448hpc2.dts | 3 ---
1 files changed, 0 insertions(+), 3 deletions(-)
diff --git a/arch/powerpc/boot/dts/mpc7448hpc2.dts
b/arch/powerpc/boot/dts/mpc7448hpc2.dts
index 4936349..d74727f 100644
--- a/arch/powerpc/boot/dts/mpc7448hpc2.dts
+++ b/arch/powerpc/boot/dts/mpc7448hpc2.dts
@@ -186,8 +186,5 @@
};
};
};
- chosen {
- linux,stdout-path =3D "/tsi108@c0000000/serial@7808";
- };
=20
};
---
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [POWERPC] mpc7448hpc2.dts: remove chosen node from dts
2008-06-30 3:03 Chunbo Luo
@ 2008-06-30 16:22 ` Segher Boessenkool
2008-06-30 18:45 ` Scott Wood
0 siblings, 1 reply; 4+ messages in thread
From: Segher Boessenkool @ 2008-06-30 16:22 UTC (permalink / raw)
To: chunbo.luo; +Cc: linuxppc-dev
> Modern versions of u-boot create a chosen node automatically. So if
> we set the chosen node in the dts file, there will be 2 chosen nodes
> passed in to the kernel,
That's a bug in uboot, then: when it creates a property, it should
delete an already existing property with the same name in that node.
> and the kernel command line will be taken from
> the wrong node. So, remove the extra chosen node from the dts file.
This will cause a regression for people using an older version of
uboot. No idea how important that is.
Segher
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [POWERPC] mpc7448hpc2.dts: remove chosen node from dts
2008-06-30 16:22 ` Segher Boessenkool
@ 2008-06-30 18:45 ` Scott Wood
0 siblings, 0 replies; 4+ messages in thread
From: Scott Wood @ 2008-06-30 18:45 UTC (permalink / raw)
To: Segher Boessenkool; +Cc: linuxppc-dev, chunbo.luo
Segher Boessenkool wrote:
>> Modern versions of u-boot create a chosen node automatically. So if
>> we set the chosen node in the dts file, there will be 2 chosen nodes
>> passed in to the kernel,
>
> That's a bug in uboot, then:
Yes, and it was fixed a while ago.
-Scott
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-06-30 18:46 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2008-06-30 4:37 [POWERPC] mpc7448hpc2.dts: remove chosen node from dts Chunbo Luo
-- strict thread matches above, loose matches on Subject: below --
2008-06-30 3:03 Chunbo Luo
2008-06-30 16:22 ` Segher Boessenkool
2008-06-30 18:45 ` Scott Wood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).