linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Grant Erickson <gerickson@nuovations.com>
Cc: linuxppc-dev@ozlabs.org, Stefan Roese <sr@denx.de>
Subject: Re: [PATCH v2] Parameterize EMAC Multicast Match Handling
Date: Tue, 01 Jul 2008 16:14:59 +1000	[thread overview]
Message-ID: <1214892899.20711.95.camel@pasglop> (raw)
In-Reply-To: <C48F0E18.101F1%gerickson@nuovations.com>

> Stefan and/or Ben:
> 
> Any thoughts on this?

I was hesitating a bit... do we really need to be -that- flexible ?

That is, either that or use some new compatible entry to detect the new
reg layout and whack that as a feature bit instead ? The advantage
of the later is that we have the possibility of doing conditional
compile for kernels that support only a given processor or set of
processors (not that we have implemented much of it, but it just
becomes Kconfig mumbo jumbo and a little bit of defines in the .h
by turning the feature test into a compile-time 0 or 1.

But this isn't a hot path and not a lot of code so maybe not worth
bothering... however, it does add 3 properties to the DT and I know
embedded people (especially Xilinx) are a bit concerned about the size
of the DT when they try to fit it in block RAM...

Cheers,
Ben.

  reply	other threads:[~2008-07-01  6:15 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-25  0:08 [PATCH v2] Parameterize EMAC Multicast Match Handling Grant Erickson
2008-07-01  5:26 ` Grant Erickson
2008-07-01  6:14   ` Benjamin Herrenschmidt [this message]
2008-07-01  6:37     ` Stefan Roese
2008-07-01 18:13       ` Grant Erickson
2008-07-01 19:42         ` Stefan Roese
2008-07-01 23:52         ` Benjamin Herrenschmidt
2008-07-05  9:18   ` [PATCH v3] ibm_newemac: " Grant Erickson
2008-07-05 22:45     ` Benjamin Herrenschmidt
2008-07-06  0:15     ` [PATCH v4] " Grant Erickson
2008-07-06  0:31       ` Benjamin Herrenschmidt
2008-07-06  9:43       ` Stefan Roese
2008-07-06 23:30       ` [PATCH v5] " Grant Erickson
2008-07-07  5:58         ` Stefan Roese
2008-07-07  6:00           ` Benjamin Herrenschmidt
2008-07-07  6:29             ` Stefan Roese
2008-07-07  6:43               ` Benjamin Herrenschmidt
2008-07-07  6:18         ` Benjamin Herrenschmidt
2008-07-07 13:59           ` Jeff Garzik
2008-07-07 19:50         ` Valentine Barshak
2008-07-07 22:02           ` Grant Erickson
2008-07-07 22:03         ` [PATCH v6] " Grant Erickson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1214892899.20711.95.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=gerickson@nuovations.com \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=sr@denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).