From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stephen Neuendorffer <stephen.neuendorffer@xilinx.com>
Cc: linuxppc-dev@ozlabs.org, git <git@xilinx.com>, dwg@au1.ibm.com
Subject: RE: [PATCH] [POWERPC] Xilinx: add compatibility for 'simple-bus'.
Date: Tue, 01 Jul 2008 16:16:44 +1000 [thread overview]
Message-ID: <1214893004.20711.97.camel@pasglop> (raw)
In-Reply-To: <20080606161932.0650C1500054@mail96-sin.bigfish.com>
On Fri, 2008-06-06 at 09:16 -0700, Stephen Neuendorffer wrote:
> legacy_serial identifies a valid ns16550 on a simple-bus, but the
> legacy_serial driver doesn't understand the shift and offset flags
> necessary to get it to work, which results in no console.
>
> I think the easiest solution is to change the Kconfig so that
> PPC_UDBG_16550 is only selected based on !XILINX_VIRTEX. I've done this
> in my tree, but I've been swamped with other things at the moment, so I
> haven't verified it.
>
> Or is legacy_serial just legacy at this point and can go away entirely?
> I got the impression from some of the earlier discussion that it wasn't
> preferred, at least....
No, legacy serial is useful. Just grow it an understanding of the shift
& offset bits :-)
Cheers,
Ben.
prev parent reply other threads:[~2008-07-01 6:16 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-07 20:47 [PATCH] [POWERPC] Xilinx: add compatibility for IBM coreconnect busses Stephen Neuendorffer
2008-05-07 22:33 ` Grant Likely
2008-05-07 22:38 ` Stephen Neuendorffer
2008-05-08 0:18 ` David Gibson
2008-05-08 2:46 ` Josh Boyer
2008-05-08 3:30 ` David Gibson
2008-05-08 11:16 ` Josh Boyer
2008-05-08 16:15 ` [PATCH] [POWERPC] Xilinx: add compatibility for IBMcoreconnect busses Stephen Neuendorffer
2008-05-08 18:25 ` [PATCH] [POWERPC] Xilinx: add compatibility for 'simple-bus' Stephen Neuendorffer
2008-05-08 18:27 ` Grant Likely
[not found] ` <1210271125-11559-1-git-send-email-stephen.neuendorffer@xilinx.com>
2008-06-03 21:41 ` Stephen Neuendorffer
2008-06-06 15:29 ` Grant Likely
2008-06-06 16:16 ` Stephen Neuendorffer
2008-06-28 20:33 ` Grant Likely
2008-06-30 3:42 ` Stephen Neuendorffer
[not found] ` <977C41F842E66D4CB2E41332313B615019F061@XSJ-EXCHVS1.xlnx.xilinx.com>
2008-06-30 14:39 ` John Linn
[not found] ` <20080630034548.A10A81750069@mail131-sin.bigfish.com>
2008-06-30 16:34 ` Grant Likely
2008-06-30 16:48 ` Stephen Neuendorffer
[not found] ` <977C41F842E66D4CB2E41332313B6150062A27B7@XSJ-EXCHVS1.xlnx.xilinx.com>
2008-06-30 16:49 ` John Linn
2008-07-01 6:16 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214893004.20711.97.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=dwg@au1.ibm.com \
--cc=git@xilinx.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=stephen.neuendorffer@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).