From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Michael Neuling <mikey@neuling.org>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH] powerpc: fix compile warning in init_thread
Date: Tue, 01 Jul 2008 19:07:36 +1000 [thread overview]
Message-ID: <1214903256.20711.123.camel@pasglop> (raw)
In-Reply-To: <1214895639.691008.114376646781.qpush@coopers>
On Tue, 2008-07-01 at 17:00 +1000, Michael Neuling wrote:
> arch/powerpc/kernel/init_task.c:33: warning: missing braces around initializer
> arch/powerpc/kernel/init_task.c:33: warning: (near initialization for 'init_task.thread.fpr[0]')
>
> Noticed by SFR.
>
> Signed-off-by: Michael Neuling <mikey@neuling.org>
That's when fpr is part of the union but what if CONFIG_VSX is off ?
Ben.
> ---
>
> include/asm-powerpc/processor.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6-ozlabs/include/asm-powerpc/processor.h
> ===================================================================
> --- linux-2.6-ozlabs.orig/include/asm-powerpc/processor.h
> +++ linux-2.6-ozlabs/include/asm-powerpc/processor.h
> @@ -222,7 +222,7 @@ struct thread_struct {
> .ksp_limit = INIT_SP_LIMIT, \
> .regs = (struct pt_regs *)INIT_SP - 1, /* XXX bogus, I think */ \
> .fs = KERNEL_DS, \
> - .fpr = {0}, \
> + .fpr = {{0}}, \
> .fpscr = { .val = 0, }, \
> .fpexc_mode = 0, \
> }
> _______________________________________________
> Linuxppc-dev mailing list
> Linuxppc-dev@ozlabs.org
> https://ozlabs.org/mailman/listinfo/linuxppc-dev
next prev parent reply other threads:[~2008-07-01 9:07 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-01 0:20 Commits added to powerpc.git master and powerpc-next branches Paul Mackerras
2008-07-01 1:27 ` Paul Mackerras
2008-07-01 1:45 ` Benjamin Herrenschmidt
2008-07-01 2:30 ` Josh Boyer
2008-07-01 2:44 ` Benjamin Herrenschmidt
2008-07-01 4:05 ` Kumar Gala
2008-07-01 2:01 ` Paul Mackerras
2008-07-01 4:01 ` [PATCH 0/2] powerpc: Update VSX support Michael Neuling
2008-07-01 4:01 ` [PATCH 1/2] powerpc: Fix compile error for CONFIG_VSX Michael Neuling
2008-07-01 4:51 ` Michael Neuling
2008-07-01 4:01 ` [PATCH 2/2] powerpc: Update for VSX core file and ptrace Michael Neuling
2008-07-01 7:00 ` [PATCH] powerpc: fix compile warning in init_thread Michael Neuling
2008-07-01 9:07 ` Benjamin Herrenschmidt [this message]
2008-07-01 11:02 ` Michael Neuling
2008-07-01 8:49 ` Commits added to powerpc.git master and powerpc-next branches Laurent Pinchart
2008-07-01 15:54 ` Jochen Friedrich
2008-07-02 7:42 ` Kumar Gala
2008-07-02 12:35 ` Jochen Friedrich
2008-07-02 15:10 ` Kumar Gala
2008-07-02 7:41 ` Kumar Gala
2008-07-02 8:41 ` Laurent Pinchart
2008-07-02 1:56 ` [PATCH] powerpc: cleanup copy_to/from_user for vsx and fpr Michael Neuling
2008-07-02 4:06 ` Michael Neuling
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1214903256.20711.123.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mikey@neuling.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).