From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 6B749DDE00 for ; Mon, 7 Jul 2008 11:15:27 +1000 (EST) Subject: Re: the printk problem From: Benjamin Herrenschmidt To: Linus Torvalds In-Reply-To: References: <20080625131101.GA6205@digi.com> <20080704104634.GA31634@digi.com> <20080704111540.ddffd241.akpm@linux-foundation.org> <1215212420.8970.8.camel@pasglop> Content-Type: text/plain; charset=utf-8 Date: Mon, 07 Jul 2008 11:14:36 +1000 Message-Id: <1215393276.8970.36.camel@pasglop> Mime-Version: 1.0 Cc: linux-ia64@vger.kernel.org, linuxppc-dev@ozlabs.org, Peter Anvin , Andrew Morton , "David S. Miller" , parisc-linux@parisc-linux.org Reply-To: benh@kernel.crashing.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2008-07-04 at 16:25 -0700, Linus Torvalds wrote: > > On Sat, 5 Jul 2008, Benjamin Herrenschmidt wrote: > > > > I'll give it a try using probe_kernel_address() instead on monday. > > Here's the updated patch which uses probe_kernel_address() instead (and > moves the whole #ifdef mess out of the code that wants it and into a > helper function - and maybe we should then put that helper into > kallsyms.h, but that's a different issue). > > Still all happily untested, of course. And still with no actual users > converted. Did a few tests and it seems to work. I'll stick a patch converting powerpc to use %pS for oops display in -next. Thanks ! Cheers, Ben.