From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Roland McGrath <roland@redhat.com>
Cc: linuxppc-dev@ozlabs.org, Nathan Lynch <ntl@pobox.com>,
linux-kernel@vger.kernel.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [PATCH 1/2] elf loader support for auxvec base platform string
Date: Mon, 07 Jul 2008 15:48:13 +1000 [thread overview]
Message-ID: <1215409693.8970.79.camel@pasglop> (raw)
In-Reply-To: <20080704021929.5E9EF1541F5@magilla.localdomain>
On Thu, 2008-07-03 at 19:19 -0700, Roland McGrath wrote:
> Why not just use ELF_HWCAP for this? It looks like powerpc only has 3 bits
> left there (keeping it to 32), but 3 is not 0. If not that, why not use
> dsocaps? That is, some magic in the vDSO, which glibc already supports on
> all machines where it uses the vDSO. (For how it works, see the use in
> arch/x86/vdso/vdso32/note.S for CONFIG_XEN.)
Well, we use strings to represent the platforms already (ie, the actual
CPU microarchitecture). Fitting those into bits would be annoying, it
makes sense to have AT_BASE_PLATFORM to be the "base" variant of
AT_PLATFORM.
_However_ there is a bug in that this patch adds an entry without
bumping the number of entries in the cached array (ie.
AT_VECTOR_SIZE_BASE needs to be updated).
Ben.
next prev parent reply other threads:[~2008-07-07 5:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 23:41 [PATCH 1/2] elf loader support for auxvec base platform string Nathan Lynch
2008-07-04 2:19 ` Roland McGrath
2008-07-07 5:48 ` Benjamin Herrenschmidt [this message]
2008-07-07 6:18 ` Roland McGrath
2008-07-07 6:23 ` Benjamin Herrenschmidt
2008-07-07 6:35 ` Roland McGrath
2008-07-07 6:48 ` Benjamin Herrenschmidt
2008-07-07 7:49 ` Andreas Schwab
2008-07-07 9:31 ` Roland McGrath
2008-07-07 10:01 ` Andreas Schwab
2008-07-07 22:56 ` Benjamin Herrenschmidt
2008-07-08 0:31 ` Roland McGrath
2008-07-08 0:48 ` Benjamin Herrenschmidt
2008-07-08 18:35 ` Steven Munroe
2008-07-07 16:16 ` Nathan Lynch
2008-07-07 22:17 ` Nathan Lynch
2008-07-07 23:00 ` Benjamin Herrenschmidt
2008-07-04 2:35 ` Mikael Pettersson
2008-07-07 15:55 ` Nathan Lynch
-- strict thread matches above, loose matches on Subject: below --
2008-07-07 15:14 Steven Munroe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1215409693.8970.79.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=ntl@pobox.com \
--cc=paulus@samba.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).