linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: linuxppc-dev@ozlabs.org
Cc: scottwood@freescale.com, arnd@arndb.de,
	Paul Gortmaker <paul.gortmaker@windriver.com>
Subject: [PATCH] legacy-serial: more meaningful names, terminate array
Date: Mon,  7 Jul 2008 11:05:20 -0400	[thread overview]
Message-ID: <1215443120-22004-1-git-send-email-paul.gortmaker@windriver.com> (raw)
In-Reply-To: <1215412426.8970.97.camel@pasglop>

Terminate the array of possible legacy serial parents, and
choose more meaningful names for better autopsy value. Fix
and cleanups as suggested by Benjamin Herrenschmidt.

Signed-off-by: Paul Gortmaker <paul.gortmaker@windriver.com>
---
 arch/powerpc/kernel/ibmebus.c       |    4 ++--
 arch/powerpc/kernel/legacy_serial.c |    5 +++--
 2 files changed, 5 insertions(+), 4 deletions(-)

diff --git a/arch/powerpc/kernel/ibmebus.c b/arch/powerpc/kernel/ibmebus.c
index 9971159..58da8f8 100644
--- a/arch/powerpc/kernel/ibmebus.c
+++ b/arch/powerpc/kernel/ibmebus.c
@@ -53,7 +53,7 @@ static struct device ibmebus_bus_device = { /* fake "parent" device */
 struct bus_type ibmebus_bus_type;
 
 /* These devices will automatically be added to the bus during init */
-static struct of_device_id __initdata builtin_matches[] = {
+static struct of_device_id __initdata ibmebus_matches[] = {
 	{ .compatible = "IBM,lhca" },
 	{ .compatible = "IBM,lhea" },
 	{},
@@ -350,7 +350,7 @@ static int __init ibmebus_bus_init(void)
 		return err;
 	}
 
-	err = ibmebus_create_devices(builtin_matches);
+	err = ibmebus_create_devices(ibmebus_matches);
 	if (err) {
 		device_unregister(&ibmebus_bus_device);
 		bus_unregister(&ibmebus_bus_type);
diff --git a/arch/powerpc/kernel/legacy_serial.c b/arch/powerpc/kernel/legacy_serial.c
index 61dd174..4b01c2b 100644
--- a/arch/powerpc/kernel/legacy_serial.c
+++ b/arch/powerpc/kernel/legacy_serial.c
@@ -33,13 +33,14 @@ static struct legacy_serial_info {
 	phys_addr_t			taddr;
 } legacy_serial_infos[MAX_LEGACY_SERIAL_PORTS];
 
-static struct __initdata of_device_id parents[] = {
+static struct __initdata of_device_id uart_match[] = {
 	{.type = "soc",},
 	{.type = "tsi-bridge",},
 	{.type = "opb", },
 	{.compatible = "ibm,opb",},
 	{.compatible = "simple-bus",},
 	{.compatible = "wrs,epld-localbus",},
+	{},
 };
 
 static unsigned int legacy_serial_count;
@@ -322,7 +323,7 @@ void __init find_legacy_serial_ports(void)
 		struct device_node *parent = of_get_parent(np);
 		if (!parent)
 			continue;
-		if (of_match_node(parents, parent) != NULL) {
+		if (of_match_node(uart_match, parent) != NULL) {
 			index = add_legacy_soc_port(np, np);
 			if (index >= 0 && np == stdout)
 				legacy_serial_console = index;
-- 
1.5.6.6.gd3e97

  parent reply	other threads:[~2008-07-07 16:25 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-07 14:25 [PATCH 0/7] Powerpc support for SBC8560 board Paul Gortmaker
     [not found] ` <ef7d84e06c45289f51f35845ccaa63bbf31827db.1199715362.git.paul.gortmaker@windriver.com>
2008-01-07 14:25   ` [PATCH 1/7] powerpc: use for_each in legacy_serial Paul Gortmaker
     [not found]   ` <f6302303b90b7e1516a1f61d85f1eafd51ec3b51.1199715362.git.paul.gortmaker@windriver.com>
2008-01-07 14:25     ` [PATCH 2/7] powerpc: allow localbus compatible serial ports for console device Paul Gortmaker
2008-01-07 14:33       ` Arnd Bergmann
2008-01-07 15:33         ` Paul Gortmaker
2008-01-07 16:04           ` Arnd Bergmann
2008-01-17 22:03             ` Paul Gortmaker
2008-01-17 22:07               ` Scott Wood
2008-01-17 22:35               ` Arnd Bergmann
2008-01-24 17:13                 ` [PATCH] powerpc: reduce code duplication in legacy_serial, add UART parent types Paul Gortmaker
2008-01-24 22:40                   ` Paul Gortmaker
2008-01-25  8:17                     ` Kumar Gala
2008-07-07  6:33                       ` Benjamin Herrenschmidt
2008-07-07 15:02                         ` Paul Gortmaker
2008-07-07 15:05                         ` Paul Gortmaker [this message]
2008-07-07 22:17                           ` [PATCH] legacy-serial: more meaningful names, terminate array Benjamin Herrenschmidt
2008-07-07 22:42                             ` [PATCH] ibmebus: more meaningful variable name Paul Gortmaker
2008-01-25  6:17                   ` [PATCH] powerpc: reduce code duplication in legacy_serial, add UART parent types Arnd Bergmann
     [not found]   ` <2e29068028918298af42b5ed07f7db147b81c921.1199715362.git.paul.gortmaker@windriver.com>
2008-01-07 14:25     ` [PATCH 3/7] sbc8560: add support for Wind River SBC8560 in arch/powerpc Paul Gortmaker
2008-01-08  0:32       ` Stephen Rothwell
2008-01-09  4:39         ` Paul Gortmaker
2008-01-09  6:23           ` Stephen Rothwell
     [not found]   ` <51ce902057aacef795405f501ad482c744a2e1f2.1199715362.git.paul.gortmaker@windriver.com>
2008-01-07 14:25     ` [PATCH 5/7] sbc8560: Convert WRS SBC8560 device tree to v1 format Paul Gortmaker
     [not found]   ` <25caba2d31cd9404db085c69e4d449dabbe56f1f.1199715362.git.paul.gortmaker@windriver.com>
2008-01-07 14:25     ` [PATCH 6/7] CPM2: Make support for the CPM2 optional on 8560 based boards Paul Gortmaker
     [not found]   ` <20d9f56839785af8a445e4cef3db98430b84b4ce.1199715362.git.paul.gortmaker@windriver.com>
2008-01-07 14:25     ` [PATCH 7/7] sbc8560: Add default .config file for Wind River SBC8560 Paul Gortmaker
     [not found]   ` <d10d083bafb978936975111f09669120201072ec.1199715362.git.paul.gortmaker@windriver.com>
2008-01-07 14:25     ` [PATCH 4/7] sbc8560: Add device tree source for Wind River SBC8560 board Paul Gortmaker
2008-01-10  2:56     ` David Gibson
2008-01-15 14:12       ` Kumar Gala
2008-01-17 20:50       ` Paul Gortmaker
2008-01-24  9:30 ` [PATCH 0/7] Powerpc support for " Kumar Gala
2008-01-24 14:17   ` Paul Gortmaker
2008-01-24 14:25     ` Kumar Gala
2008-01-24 14:27       ` Paul Gortmaker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1215443120-22004-1-git-send-email-paul.gortmaker@windriver.com \
    --to=paul.gortmaker@windriver.com \
    --cc=arnd@arndb.de \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=scottwood@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).