From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Subject: Re: linux-next: kbuild tree build failure From: Michael Ellerman To: Roman Zippel In-Reply-To: References: <20080707184038.aaeb8d40.sfr@canb.auug.org.au> Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="=-pSyg6s/7lnZPVPuDon/n" Date: Tue, 08 Jul 2008 09:36:38 +1000 Message-Id: <1215473798.8138.4.camel@localhost> Mime-Version: 1.0 Cc: Stephen Rothwell , linux-next@vger.kernel.org, Paul Mackerras , Sam Ravnborg , linuxppc-dev@ozlabs.org Reply-To: michael@ellerman.id.au List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , --=-pSyg6s/7lnZPVPuDon/n Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Mon, 2008-07-07 at 18:13 +0200, Roman Zippel wrote: > Hi, >=20 > On Mon, 7 Jul 2008, Stephen Rothwell wrote: >=20 > > Hi Sam, > >=20 > > Today's linux-next build (powerpc ppc64_defconfig) failed like this: > >=20 > > arch/powerpc/platforms/cell/spu_base.c: In function '__spu_trap_data_se= g': > > arch/powerpc/platforms/cell/spu_base.c:194: error: duplicate case value > > arch/powerpc/platforms/cell/spu_base.c:177: error: previously used here >=20 > I guess there also has been a kconfig warning somewhere. :) > I should have gone through all archs to test this, sorry about that. > Luckily it's only powerpc that uses 64bit values. I would prefer to=20 > standardize on 32bit values, as it doesn't really make sense to expect=20 > from the user to input full 64bit values and it's easy to generate the=20 > full value in a header. This would also ease on any portability issues=20 > (kconfig is compiled with the host compiler not the target compiler). Hi Roman, I don't really see why it "doesn't make sense" for users to input 64-bit values, they're configuring addresses for a 64-bit kernel, so some of the values are going to be 64 bit. Perhaps all the current values can be generated by shifting 32-bit constants, but that seems like a hack to me. Another comment below .. > Index: linux-2.6/arch/powerpc/Kconfig > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > --- linux-2.6.orig/arch/powerpc/Kconfig > +++ linux-2.6/arch/powerpc/Kconfig > @@ -714,8 +714,8 @@ config PHYSICAL_START_BOOL > =20 > config PHYSICAL_START > hex "Physical address where the kernel is loaded" if PHYSICAL_START_BOO= L > - default "0x02000000" if PPC_STD_MMU && CRASH_DUMP > - default "0x00000000" > + default "0x2000000" if PPC_STD_MMU && CRASH_DUMP > + default "0" > =20 > config PHYSICAL_ALIGN > hex > @@ -763,7 +763,7 @@ config CONSISTENT_SIZE_BOOL > =20 > config CONSISTENT_SIZE > hex "Size of consistent memory pool" if CONSISTENT_SIZE_BOOL > - default "0x00200000" if NOT_COHERENT_CACHE > + default "0x200000" if NOT_COHERENT_CACHE > =20 > config PIN_TLB > bool "Pinned Kernel TLBs (860 ONLY)" > @@ -773,15 +773,11 @@ endmenu > if PPC64 > config PAGE_OFFSET > hex > - default "0xc000000000000000" > -config KERNEL_START > - hex > - default "0xc000000002000000" if CRASH_DUMP > - default "0xc000000000000000" > + default "0xc0000000" I don't see where you cope with the "if CRASH_DUMP" case, and in fact my config changes for the worse when I apply your patch and regenerate my config: --- .config.orig 2008-07-08 09:30:00.000000000 +1000 +++ .config 2008-07-08 09:30:43.000000000 +1000 @@ -370,9 +370,8 @@ CONFIG_HOTPLUG_PCI_RPA=3Dm CONFIG_HOTPLUG_PCI_RPA_DLPAR=3Dm # CONFIG_HAS_RAPIDIO is not set -CONFIG_PAGE_OFFSET=3D0xc000000000000000 -CONFIG_KERNEL_START=3D0xc000000002000000 -CONFIG_PHYSICAL_START=3D0x02000000 +CONFIG_PAGE_OFFSET=3D0xc0000000 +CONFIG_PHYSICAL_START=3D0x2000000 =20 cheers --=20 Michael Ellerman OzLabs, IBM Australia Development Lab wwweb: http://michael.ellerman.id.au phone: +61 2 6212 1183 (tie line 70 21183) We do not inherit the earth from our ancestors, we borrow it from our children. - S.M.A.R.T Person --=-pSyg6s/7lnZPVPuDon/n Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.6 (GNU/Linux) iD8DBQBIcqiGdSjSd0sB4dIRAm/kAKCCsZAv+elDY5jl4Pn4Er5Hg9d+9QCfTeUP yIAsxyvkIy2ZjkBHqsxCpA4= =6DZ4 -----END PGP SIGNATURE----- --=-pSyg6s/7lnZPVPuDon/n--