From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Stephen Rothwell <sfr@canb.auug.org.au>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>
Subject: Re: powerpc: Add proper reference to dma_mask
Date: Tue, 08 Jul 2008 14:28:11 +1000 [thread overview]
Message-ID: <1215491291.8970.195.camel@pasglop> (raw)
In-Reply-To: <20080708135426.43edb5dc.sfr@canb.auug.org.au>
On Tue, 2008-07-08 at 13:54 +1000, Stephen Rothwell wrote:
> Hi Vitaly,
>
> On Tue, 8 Jul 2008 03:12:56 +0400 Vitaly Bordug <vitb@kernel.crashing.org> wrote:
> >
> > +++ b/arch/powerpc/kernel/of_platform.c
> > @@ -76,6 +76,9 @@ struct of_device* of_platform_device_create(struct device_node *np,
> > return NULL;
> >
> > dev->dma_mask = 0xffffffffUL;
> > + dev->dev.dma_mask = &dev->dma_mask;
>
> That is done in of_device_alloc which is called just above.
So the problem might just be that coherent_dma_mask isn't set.
Ben.
next prev parent reply other threads:[~2008-07-08 4:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 23:12 powerpc: Add proper reference to dma_mask Vitaly Bordug
2008-07-08 3:54 ` Stephen Rothwell
2008-07-08 4:28 ` Benjamin Herrenschmidt [this message]
2008-07-08 12:48 ` Vitaly Bordug
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1215491291.8970.195.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).