linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: rework 4xx PTE access and TLB miss
Date: Thu, 10 Jul 2008 06:04:16 +1000	[thread overview]
Message-ID: <1215633856.8970.374.camel@pasglop> (raw)
In-Reply-To: <352560B5-24A4-47B8-8A1F-5900957470FC@kernel.crashing.org>

On Wed, 2008-07-09 at 10:31 -0500, Kumar Gala wrote:
> > v3. Relying on the generic code to fixup _PAGE_ACCESSED doesn't
> > work for exec faults because our cache coherency code in
> > do_page_fault() will never go all the way to the generic code
> > for these. We fix it up by always setting _PAGE_ACCESSED when
> > setting _PAGE_HWEXEC in there.
> > This version of the patch is rebased on top of -next
> 
> shouldn't you remove _PAGE_HWWRITE from 40x?  (I'm still seeing it
> in  
> pgtable-ppc32.h and head_40x.S)

I haven't updated 40x at all yet.

Ben.

  reply	other threads:[~2008-07-09 20:04 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-08  5:54 [PATCH] powerpc: rework 4xx PTE access and TLB miss Benjamin Herrenschmidt
2008-07-09  0:53 ` Sean MacLennan
2008-07-09  1:53   ` Benjamin Herrenschmidt
2008-07-09 14:23 ` Josh Boyer
2008-07-09 16:36   ` Josh Boyer
2008-07-09 15:31 ` Kumar Gala
2008-07-09 20:04   ` Benjamin Herrenschmidt [this message]
  -- strict thread matches above, loose matches on Subject: below --
2008-07-01  4:35 Benjamin Herrenschmidt
2008-07-07 14:06 ` Josh Boyer
2008-07-07 22:03   ` Benjamin Herrenschmidt
2008-07-08  1:25     ` Josh Boyer
2008-07-08  1:34       ` Benjamin Herrenschmidt
2008-07-08  4:58       ` Benjamin Herrenschmidt
2008-07-07 22:48   ` Sean MacLennan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1215633856.8970.374.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=galak@kernel.crashing.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).