From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Srinivasa D S <srinivasa@in.ibm.com>
Cc: linuxppc-dev@ozlabs.org, Paul Mackerras <paulus@samba.org>
Subject: Re: [RFC] [PATCH] task_pt_regs for powerpc systems
Date: Mon, 14 Jul 2008 19:06:57 +1000 [thread overview]
Message-ID: <1216026417.7549.270.camel@pasglop> (raw)
In-Reply-To: <200807141401.26917.srinivasa@in.ibm.com>
On Mon, 2008-07-14 at 14:01 +0530, Srinivasa D S wrote:
> On Monday 14 July 2008 04:02:41 am Paul Mackerras wrote:
> > > Below attached patch defines this macro for powerpc arch. Please let
> > > me know your comments on this.
> > >
> > > +#define task_pt_regs(tsk) ((struct pt_regs *)(tsk)->thread.regs)
> >
> > The cast is unnecessary since tsk->thread.regs is already a struct
> > pt_regs *.
>
> True.
>
> > Also note that tsk->thread.regs will be NULL for a kernel
> > thread.
>
> Yes, users of task_pt_regs will verify for NULL. Updated patch attached
> below.
>
> Signed-off-by: Srinivasa DS <srinivasa@in.ibm.com>
Can you send a cleanup patch against powerpc.git instead ?
Thanks !
Ben
next prev parent reply other threads:[~2008-07-14 10:05 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 14:22 [RFC] [PATCH] task_pt_regs for powerpc systems Srinivasa D S
2008-07-08 6:21 ` Benjamin Herrenschmidt
2008-07-13 22:32 ` Paul Mackerras
2008-07-13 22:40 ` Benjamin Herrenschmidt
2008-07-14 8:31 ` Srinivasa D S
2008-07-14 9:06 ` Benjamin Herrenschmidt [this message]
2008-07-15 9:06 ` Srinivasa D S
2008-07-15 9:15 ` Benjamin Herrenschmidt
2008-07-15 10:30 ` Srinivasa DS
2008-07-15 10:37 ` Benjamin Herrenschmidt
2008-07-14 17:21 ` Timur Tabi
2008-07-14 17:36 ` Andreas Schwab
2008-07-15 9:21 ` Srinivasa D S
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1216026417.7549.270.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
--cc=srinivasa@in.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).