From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 6842DDE0E3 for ; Fri, 25 Jul 2008 17:51:16 +1000 (EST) Subject: Re: sfx.c driver build failure From: Benjamin Herrenschmidt To: Michael Brown In-Reply-To: References: <1216966559.11188.85.camel@pasglop> Content-Type: text/plain; charset=utf-8 Date: Fri, 25 Jul 2008 17:50:57 +1000 Message-Id: <1216972257.11188.96.camel@pasglop> Mime-Version: 1.0 Cc: linuxppc-dev list , Jeff Garzik , Linux Kernel list Reply-To: benh@kernel.crashing.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2008-07-25 at 08:35 +0100, Michael Brown wrote: > On Fri, 25 Jul 2008, Benjamin Herrenschmidt wrote: > > The sfx driver (which happens to be part of some of our test configs) > > fails to build in current Linus tree on powerpc with this error: > > > > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c: In function ÿÿefx_probe_interruptsÿÿ: > > /home/benh/kernels/linux-powerpc/drivers/net/sfc/efx.c:845: error: lvalue required as unary ÿÿ&ÿÿ oper > > and > > I'm not the maintainer of that code; I wrote the original version, but > it's now maintained by Solarflare. > > I don't see anything on that line that ought to be architecture-specific. > Could you send me the preprocessed efx.c from your powerpc build? Apparently, it's a know generic breakage of the topology stuff, it's beeing sorted out. Cheers, Ben.