From: Daniel Walker <dwalker@mvista.com>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: spi-devel-general@lists.sourceforge.net,
dbrownell@users.sourceforge.net, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc/mpc5200: Fix locking on mpc52xx_spi driver
Date: Sat, 26 Jul 2008 08:35:50 -0400 [thread overview]
Message-ID: <1217075750.3970.16.camel@localhost.localdomain> (raw)
In-Reply-To: <20080726062226.10506.65539.stgit@trillian.secretlab.ca>
On Sat, 2008-07-26 at 02:24 -0400, Grant Likely wrote:
> From: Grant Likely <grant.likely@secretlab.ca>
>
> Locking was incorrect for the state machine processing since there are
> conditions where both the work queue and the IRQ can be active. This
> patch fixes the handling to ensure the spin lock is held whenever the
> state machine is being processed.
>
> Signed-off-by: Grant Likely <grant.likely@secretlab.ca>
> ---
>
> Hi Daniel,
>
> Here is the incremental change to the mpc52xx_spi driver to fix up the
> locking. It should be safe and unambiguous now.
Thank you, it looks much better..
Daniel
next prev parent reply other threads:[~2008-07-26 12:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-26 6:24 [PATCH] powerpc/mpc5200: Fix locking on mpc52xx_spi driver Grant Likely
2008-07-26 12:35 ` Daniel Walker [this message]
2008-07-27 20:45 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217075750.3970.16.camel@localhost.localdomain \
--to=dwalker@mvista.com \
--cc=dbrownell@users.sourceforge.net \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@ozlabs.org \
--cc=spi-devel-general@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).