From: David Woodhouse <dwmw2@infradead.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Use new printk extension %pS to print symbols on oops
Date: Sun, 27 Jul 2008 01:40:30 -0400 [thread overview]
Message-ID: <1217137231.1769.33.camel@shinybook.infradead.org> (raw)
In-Reply-To: <alpine.LFD.1.10.0807071006270.11076@woody.linux-foundation.org>
On Mon, 2008-07-07 at 10:08 -0700, Linus Torvalds wrote:
> On Mon, 7 Jul 2008, Benjamin Herrenschmidt wrote:
> >
> > This changes the oops and backtrace code to use the new %pS
> > printk extension to print out symbols rather than manually
> > calling print_symbol.
>
> Ok, I ended up committing the suppor for '%pS' early (as a series of
> smaller patches to make it clearer), just because it makes it easier for
> different people to start converthing things with the infrastructure in
> place.
Out of interest, why is it %pS and not %Sp? Shouldn't the modifier come
first? What if we want to print a pointer immediately followed by a
capital S?
--
David Woodhouse Open Source Technology Centre
David.Woodhouse@intel.com Intel Corporation
next prev parent reply other threads:[~2008-07-27 5:40 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-07 3:44 [PATCH] powerpc: Use new printk extension %pS to print symbols on oops Benjamin Herrenschmidt
2008-07-07 17:08 ` Linus Torvalds
2008-07-07 22:20 ` Benjamin Herrenschmidt
2008-07-27 5:40 ` David Woodhouse [this message]
2008-07-27 17:26 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1217137231.1769.33.camel@shinybook.infradead.org \
--to=dwmw2@infradead.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).