linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Michael Ellerman <michael@ellerman.id.au>
To: Tony Breeds <tony@bakeyournoodle.com>
Cc: Paul Mackerras <paulus@samba.org>, linuxppc-dev@ozlabs.org
Subject: Re: [PATCH 6/8] Explictly undefine DEBUG in arch/powerpc/platforms/pseries/eeh_driver.c
Date: Thu, 31 Jul 2008 14:53:30 +1000	[thread overview]
Message-ID: <1217480010.1487.38.camel@localhost> (raw)
In-Reply-To: <c5fdfe03bcac5d6964b6712a2a15ab0edc12ce83.1217476198.git.tony@bakeyournoodle.com>

[-- Attachment #1: Type: text/plain, Size: 616 bytes --]

On Thu, 2008-07-31 at 13:51 +1000, Tony Breeds wrote:
> print_device_node_tree() is guarded by DEBUG but even when declared, it
> isn't called.  Explicitly undefine DEBUG as you'll need to modify this
> file anyway to use print_device_node_tree().

Please don't, it breaks CONFIG_PPC_PSERIES_DEBUG.

cheers

/me refrains from ranting about stupid -Werror

-- 
Michael Ellerman
OzLabs, IBM Australia Development Lab

wwweb: http://michael.ellerman.id.au
phone: +61 2 6212 1183 (tie line 70 21183)

We do not inherit the earth from our ancestors,
we borrow it from our children. - S.M.A.R.T Person

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 189 bytes --]

  reply	other threads:[~2008-07-31  4:53 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-31  3:51 [PATCH 1/8] Guard linkstation_physmap_partitions Tony Breeds
2008-07-31  3:51 ` [PATCH 2/8] Guard htab_dt_scan_hugepage_blocks appropriately Tony Breeds
2008-07-31  3:51 ` [PATCH 3/8] Silennce warning in arch/powerpc/mm/mem.c Tony Breeds
2008-07-31  3:51 ` [PATCH 8/8] Enable -Werror in arch/powerpc/{kernel,lib,mm,platforms} Tony Breeds
2008-07-31  3:51 ` [PATCH 6/8] Explictly undefine DEBUG in arch/powerpc/platforms/pseries/eeh_driver.c Tony Breeds
2008-07-31  4:53   ` Michael Ellerman [this message]
2008-07-31  6:54   ` [PATCH v2] Guard print_device_node_tree() if #if 0 Tony Breeds
2008-07-31  3:51 ` [PATCH 5/8] Silence warning in arch/powerpc/mm/ppc_mmu_32.c Tony Breeds
2008-07-31  5:21   ` Stephen Rothwell
2008-07-31  6:54     ` Milton Miller
2008-08-01  1:40       ` Tony Breeds
2008-07-31  6:58     ` Tony Breeds
2008-07-31  6:57   ` [PATCH v2] Force printing of 'total_memory' to unsigned long long in ppc_mmu_32.c Tony Breeds
2008-08-01  1:38     ` [PATCH v3] " Tony Breeds
2008-07-31  3:51 ` [PATCH 7/8] Guard from_rtc_time() in arch/powerpc/platforms/powermac/time.c Tony Breeds
2008-07-31  3:51 ` [PATCH 4/8] Silence warnings in arch/powerpc/platforms/52xx/mpc52xx_pci.c Tony Breeds
2008-07-31  4:08   ` Jon Smirl
2008-07-31  4:21     ` Tony Breeds
2008-07-31  5:27     ` Grant Likely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1217480010.1487.38.camel@localhost \
    --to=michael@ellerman.id.au \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=paulus@samba.org \
    --cc=tony@bakeyournoodle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).