From: Dave Hansen <dave@linux.vnet.ibm.com>
To: Mel Gorman <mel@csn.ul.ie>
Cc: linux-mm@kvack.org, libhugetlbfs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, linuxppc-dev@ozlabs.org,
abh@cray.com, ebmunson@us.ibm.com,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [RFC] [PATCH 0/5 V2] Huge page backed user-space stacks
Date: Wed, 06 Aug 2008 12:50:49 -0700 [thread overview]
Message-ID: <1218052249.10907.125.camel@nimitz> (raw)
In-Reply-To: <20080806090222.GD21190@csn.ul.ie>
On Wed, 2008-08-06 at 10:02 +0100, Mel Gorman wrote:
> > That said, this particular patch doesn't appear *too* bound to hugetlb
> > itself. But, some of its limitations *do* come from the filesystem,
> > like its inability to handle VM_GROWS...
>
> The lack of VM_GROWSX is an issue, but on its own it does not justify
> the amount of churn necessary to support direct pagetable insertions for
> MAP_ANONYMOUS|MAP_PRIVATE. I think we'd need another case or two that would
> really benefit from direct insertions to pagetables instead of hugetlbfs so
> that the path would get adequately tested.
I'm jumping around here a bit, but I'm trying to get to the core of what
my problem with these patches is. I'll see if I can close the loop
here.
The main thing this set of patches does that I care about is take an
anonymous VMA and replace it with a hugetlb VMA. It does this on a
special cue, but does it nonetheless.
This patch has crossed a line in that it is really the first
*replacement* of a normal VMA with a hugetlb VMA instead of the creation
of the VMAs at the user's request. I'm really curious what the plan is
to follow up on this. Will this stack stuff turn out to be one-off
code, or is this *the* route for getting transparent large pages in the
future?
Because of the limitations like its inability to grow the VMA, I can't
imagine that this would be a generic mechanism that we can use
elsewhere.
-- Dave
next prev parent reply other threads:[~2008-08-06 19:51 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-28 19:17 [RFC] [PATCH 0/5 V2] Huge page backed user-space stacks Eric Munson
2008-07-28 19:17 ` [PATCH 1/5 V2] Align stack boundaries based on personality Eric Munson
2008-07-28 20:09 ` Dave Hansen
2008-07-28 19:17 ` [PATCH 2/5 V2] Add shared and reservation control to hugetlb_file_setup Eric Munson
2008-07-28 19:17 ` [PATCH 3/5] Split boundary checking from body of do_munmap Eric Munson
2008-07-28 19:17 ` [PATCH 4/5 V2] Build hugetlb backed process stacks Eric Munson
2008-07-28 20:37 ` Dave Hansen
2008-07-28 19:17 ` [PATCH 5/5 V2] [PPC] Setup stack memory segment for hugetlb pages Eric Munson
2008-07-28 20:33 ` [RFC] [PATCH 0/5 V2] Huge page backed user-space stacks Dave Hansen
2008-07-28 21:23 ` Eric B Munson
2008-07-30 8:41 ` Andrew Morton
2008-07-30 15:04 ` Eric B Munson
2008-07-30 15:08 ` Eric B Munson
2008-07-30 8:43 ` Andrew Morton
2008-07-30 17:23 ` Mel Gorman
2008-07-30 17:34 ` Andrew Morton
2008-07-30 19:30 ` Mel Gorman
2008-07-30 19:40 ` Christoph Lameter
2008-07-30 20:07 ` Andrew Morton
2008-07-31 10:31 ` Mel Gorman
2008-08-04 21:10 ` Dave Hansen
2008-08-05 11:11 ` Mel Gorman
2008-08-05 16:12 ` Dave Hansen
2008-08-05 16:28 ` Mel Gorman
2008-08-05 17:53 ` Dave Hansen
2008-08-06 9:02 ` Mel Gorman
2008-08-06 19:50 ` Dave Hansen [this message]
2008-08-07 16:06 ` Mel Gorman
2008-08-07 17:29 ` Dave Hansen
2008-08-11 8:04 ` Mel Gorman
2008-07-31 6:04 ` Nick Piggin
2008-07-31 6:14 ` Andrew Morton
2008-07-31 6:26 ` Nick Piggin
2008-07-31 11:27 ` Mel Gorman
2008-07-31 11:51 ` Nick Piggin
2008-07-31 13:50 ` Mel Gorman
2008-07-31 14:32 ` Michael Ellerman
2008-08-06 18:49 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1218052249.10907.125.camel@nimitz \
--to=dave@linux.vnet.ibm.com \
--cc=abh@cray.com \
--cc=akpm@linux-foundation.org \
--cc=ebmunson@us.ibm.com \
--cc=libhugetlbfs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mel@csn.ul.ie \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).