linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Darcy Watkins <dwatkins@tranzeo.com>
To: linuxppc-embedded <linuxppc-embedded@ozlabs.org>
Subject: Re: Strange Badness with RT Spin Lock
Date: Mon, 11 Aug 2008 08:30:52 -0700	[thread overview]
Message-ID: <1218468652.3465.60.camel@localhost> (raw)
In-Reply-To: <1218225371.3465.51.camel@localhost>

Further to what I reported earlier regarding my unusual bug, adding a
memory barrier such as shown below also prevents the oops (and is a lot
cleaner than putting in unused dummy static instance(s) of spinlocks).

This has me scratching my head.  Isn't the PPC405EP a uni-processor?  I
suppose my problem could be an interaction of RT-Preemption with
predictive loads / deferred stores or perhaps there is a memory barrier
related bug in the spinlock/rtmutex code?.


>         // We dispatch the PDU.
>          ...
> 
> #ifdef USE_MUTEX_CHECK_HACK
>          MUTEX_CHECK_SAVE_LOCKED;
> #endif
>          spin_unlock(&tree_lock);
> #ifdef USE_MUTEX_CHECK_HACK
>          rt_mutex_owner_check("process_packed_pdu() - no frag - before
> cblk()");
>          MUTEX_CHECK_SAVE_UNLOCKED;
> #endif
>          clbk(new_skb, gen_header_p->cid);
> 
> 

         barrier(); // memory barrier

> #ifdef USE_MUTEX_CHECK_HACK
>          MUTEX_CHECK_DUMP_ON_BUG;
>          rt_mutex_owner_check("process_packed_pdu() - no frag - after
> cblk()");
> #endif
>          spin_lock(&tree_lock);




On Fri, 2008-08-08 at 12:56 -0700, Darcy Watkins wrote:
> Hello,
> 
> I have a very unusual bug I have been trying to get to the bottom of.
> 
--snip!--


-- 


Regards,

Darcy

--------------
Darcy L. Watkins - Senior Software Developer
Tranzeo Wireless Technologies, Inc.
19273 Fraser Way, Pitt Meadows, BC, Canada V3Y 2V4
T:604-460-6002 ext:410
http://www.tranzeo.com

  reply	other threads:[~2008-08-11 15:30 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-08 19:56 Strange Badness with RT Spin Lock Darcy Watkins
2008-08-11 15:30 ` Darcy Watkins [this message]
2008-08-13 19:55 ` Darcy Watkins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1218468652.3465.60.camel@localhost \
    --to=dwatkins@tranzeo.com \
    --cc=linuxppc-embedded@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).