linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Vitaly Bordug <vitb@kernel.crashing.org>
Cc: "linuxppc-dev@ozlabs.org" <linuxppc-dev@ozlabs.org>,
	Stefan Roese <sr@denx.de>,
	"linux-usb-devel@lists.sourceforge.net"
	<linux-usb-devel@lists.sourceforge.net>,
	Mark Miesfeld <mmiesfeld@amcc.com>
Subject: Re: [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errrata
Date: Tue, 19 Aug 2008 12:03:42 +1000	[thread overview]
Message-ID: <1219111423.8062.10.camel@pasglop> (raw)
In-Reply-To: <20080819021040.27ce7dbe@vitb-lp>


 .../...

> There is a software workaround that uses a trick to detect if full-speed interface 
> is enabled from the hi-speed driver(and vice versa), and use suspend control for ohci
> to enable/disable it appropriately.
>  
> Initial version of the software workaround was posted to linux-usb-devel:
> 
> http://www.mail-archive.com/linux-usb-devel@lists.sourceforge.net/msg54019.html
> 
> and later were made available from amcc.com:
> http://www.amcc.com/Embedded/Downloads/download.html?cat=1&family=15&ins=2
> 
> The patch below is generally based on the latter, but reworked to
> powerpc/of_device USB drivers, and uses a few devicetree inquiries to get
> rid of (some) hardcoded defines.

Well, it seems to still call things based on #ifdef CONFIG_* instead
of testing for whatever "errata" bit or flag you can initialize.

A proper approach is to have the OF probe code detect via some
device-tree compatible testing or such, that it's indeed hitting the
broken chip, use that to set a quirk in the controller, and then
have the core ehci-hub.c code do whatever it has to do based on
the presence of that quirk.

Ben.

  reply	other threads:[~2008-08-19  2:04 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-18 22:10 [RFC][USB] powerpc: Workaround for the PPC440EPX USBH_23 errrata Vitaly Bordug
2008-08-19  2:03 ` Benjamin Herrenschmidt [this message]
2008-08-20 21:03   ` Vitaly Bordug

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1219111423.8062.10.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=linuxppc-dev@ozlabs.org \
    --cc=mmiesfeld@amcc.com \
    --cc=sr@denx.de \
    --cc=vitb@kernel.crashing.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).