From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Paul Mackerras <paulus@samba.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] powerpc: Only make kernel text pages of linear mapping executable
Date: Thu, 28 Aug 2008 16:58:21 +1000 [thread overview]
Message-ID: <1219906701.13162.304.camel@pasglop> (raw)
In-Reply-To: <18614.18410.958014.376185@cargo.ozlabs.ibm.com>
On Thu, 2008-08-28 at 16:38 +1000, Paul Mackerras wrote:
> Commit bc033b63bbfeb6c4b4eb0a1d083c650e4a0d2af8 ("powerpc/mm: Fix
> attribute confusion with htab_bolt_mapping()") moved the check for
> whether we should make pages of the linear mapping executable from
> htab_bolt_mapping into its callers, including htab_initialize.
> A side-effect of this is that the decision is now made once for
> each contiguous section in the LMB array rather than for each page
> individually. This can often mean that the whole of the linear
> mapping ends up being executable.
>
> This reverts to the previous behaviour, where individual pages are
> checked for being part of the kernel text or not, by moving the check
> back down into htab_bolt_mapping.
>
> Signed-off-by: Paul Mackerras <paulus@samba.org>
Acked-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
prev parent reply other threads:[~2008-08-28 6:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 6:38 [PATCH] powerpc: Only make kernel text pages of linear mapping executable Paul Mackerras
2008-08-28 6:58 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1219906701.13162.304.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).