From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 3EBA1DE472 for ; Fri, 29 Aug 2008 00:58:34 +1000 (EST) Subject: Re: [BUG] linux-next: Tree for August 26 - Badness at kernel/notifier.c:25 From: David Woodhouse To: Stephen Rothwell In-Reply-To: <1219933410.7107.296.camel@pmac.infradead.org> References: <20080826184008.6be39f19.sfr@canb.auug.org.au> <48B44B2D.8070809@linux.vnet.ibm.com> <48B46610.1010809@linux.intel.com> <48B53695.3020703@linux.vnet.ibm.com> <48B55B16.7060804@linux.intel.com> <20080828003308.400038e0.sfr@canb.auug.org.au> <20080828003821.d29d2a03.sfr@canb.auug.org.au> <1219933410.7107.296.camel@pmac.infradead.org> Content-Type: text/plain Date: Thu, 28 Aug 2008 15:55:07 +0100 Message-Id: <1219935307.7107.302.camel@pmac.infradead.org> Mime-Version: 1.0 Cc: LKML , Kamalesh Babulal , linuxppc-dev@ozlabs.org, linux-next@vger.kernel.org, mingo@elte.hu, Arjan van de Ven List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Thu, 2008-08-28 at 15:23 +0100, David Woodhouse wrote: > On Thu, 2008-08-28 at 00:38 +1000, Stephen Rothwell wrote: > > Hi Arjan, > > > > On Thu, 28 Aug 2008 00:33:08 +1000 Stephen Rothwell wrote: > > > > > > The original reported trace was during setup_system which is very early in > > > the boot. > > > > But, of course, that version didn't have the necessary extra dereference > > of the function address ... > > > > And the later debug patch did not check the address at register time, > > only at notify time. > > > > The later trace also looks to be early in the boot. > > It's isa_bridge_notify(), which is neither within _[se]text nor > _[se]inittext, so the core_kernel_text() function disavows it. > > Where are __devinit functions supposed to end up? The TEXT_TEXT macro defined in should get this right... but we don't use it. Is there any particular reason for that, or should we.... Signed-off-by: David Woodhouse --- linux-2.6.26.ppc64/arch/powerpc/kernel/vmlinux.lds.S~ 2008-07-13 22:51:29.000000000 +0100 +++ linux-2.6.26.ppc64/arch/powerpc/kernel/vmlinux.lds.S 2008-08-28 15:39:14.000000000 +0100 @@ -35,10 +35,11 @@ SECTIONS ALIGN_FUNCTION(); *(.text.head) _text = .; - *(.text .fixup .text.init.refok .exit.text.refok) + TEXT_TEXT SCHED_TEXT LOCK_TEXT KPROBES_TEXT + *(.fixup) #ifdef CONFIG_PPC32 *(.got1) -- David Woodhouse Open Source Technology Centre David.Woodhouse@intel.com Intel Corporation