From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 601A8DDFD7 for ; Tue, 2 Sep 2008 18:20:01 +1000 (EST) Subject: Re: Trace From: Benjamin Herrenschmidt To: =?ISO-8859-1?Q?S=E9bastien_Chr=E9tien?= In-Reply-To: <319b0ac50809020034m12b4d57cj1fdf31f3282935e6@mail.gmail.com> References: <319b0ac50809010216jac3ae30r9260699abde6535@mail.gmail.com> <929D3CED81F34E43887A393170D66FB926B259@GBRSUN01MS002.eu.xerox.net> <319b0ac50809010525w7451ef92m5aaf6fd5f5a8958e@mail.gmail.com> <929D3CED81F34E43887A393170D66FB926B40F@GBRSUN01MS002.eu.xerox.net> <929D3CED81F34E43887A393170D66FB926B41A@GBRSUN01MS002.eu.xerox.net> <48BC195F.4070505@gmail.com> <1220314383.13010.62.camel@pasglop> <48BCCB6D.5040209@fr.thalesgroup.com> <1220334314.13010.89.camel@pasglop> <319b0ac50809020034m12b4d57cj1fdf31f3282935e6@mail.gmail.com> Content-Type: text/plain; charset=utf-8 Date: Tue, 02 Sep 2008 18:19:50 +1000 Message-Id: <1220343590.13010.118.camel@pasglop> Mime-Version: 1.0 Cc: =?ISO-8859-1?Q?S=E9bastien?= CHRETIEN , linuxppc-dev@ozlabs.org, "Jenkins, Clive" Reply-To: benh@kernel.crashing.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Tue, 2008-09-02 at 09:34 +0200, Sébastien Chrétien wrote: > ok is it a bad way to write a tty driver ? why ? Not necessarily, it's just overkill. The UART layer handles a lot of stuff for you. The tty layer is tricky to get right. Cheers, Ben.