From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v3 3/4] powerpc/fsl-booke: Fixup 64-bit PTE reading for SMP support
Date: Thu, 04 Sep 2008 13:14:22 +1000 [thread overview]
Message-ID: <1220498062.4879.38.camel@pasglop> (raw)
In-Reply-To: <1220465344-16753-3-git-send-email-galak@kernel.crashing.org>
> FIND_PTE
> andc. r13,r13,r11 /* Check permission */
> - bne 2f /* Bail if permission mismach */
>
> #ifdef CONFIG_PTE_64BIT
> - lwz r13, 0(r12)
> +#ifdef CONFIG_SMP
> + subf r10, r11, r12 /* create false data dep */
> + lwzx r13, r11, r10 /* Get upper pte bits */
> +#else
> + lwz r13, 0(r12) /* Get upper pte bits */
> #endif
> +#endif
Minor nit, but we don't usually use spaces after "," in asm.
Cheers,
Ben.
next prev parent reply other threads:[~2008-09-04 3:14 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-03 18:09 [PATCH v3 1/4] powerpc: Introduce local (non-broadcast) forms of tlb invalidates Kumar Gala
2008-09-03 18:09 ` [PATCH v3 2/4] powerpc: Fixes for CONFIG_PTE_64BIT for SMP support Kumar Gala
2008-09-03 18:09 ` [PATCH v3 3/4] powerpc/fsl-booke: Fixup 64-bit PTE reading " Kumar Gala
2008-09-03 18:09 ` [PATCH v3 4/4] powerpc/mm: Implement _PAGE_SPECIAL & pte_special() for 32-bit Kumar Gala
2008-09-04 3:15 ` Benjamin Herrenschmidt
2008-09-04 3:14 ` Benjamin Herrenschmidt [this message]
2008-09-04 3:12 ` [PATCH v3 2/4] powerpc: Fixes for CONFIG_PTE_64BIT for SMP support Benjamin Herrenschmidt
2008-09-05 19:44 ` Kumar Gala
2008-09-05 22:38 ` Benjamin Herrenschmidt
2008-09-06 15:32 ` Kumar Gala
2008-09-04 19:17 ` [PATCH v3 1/4] powerpc: Introduce local (non-broadcast) forms of tlb invalidates Rafal Jaworowski
2008-09-04 21:30 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1220498062.4879.38.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).