From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Sebastien Dugue <sebastien.dugue@bull.net>
Cc: dwalker@mvista.com, tinytim@us.ibm.com,
linux-rt-users@vger.kernel.org, jean-pierre.dion@bull.net,
rostedt@goodmis.org, linux-kernel@vger.kernel.org,
michael@ellerman.id.au, linuxppc-dev@ozlabs.org,
paulus@samba.org, gilles.carry@ext.bull.net, tglx@linutronix.de
Subject: Re: [PATCH 2/2] powerpc - Make the irq reverse mapping radix tree lockless
Date: Thu, 04 Sep 2008 17:34:03 +1000 [thread overview]
Message-ID: <1220513643.4879.68.camel@pasglop> (raw)
In-Reply-To: <20080904092252.12b3df4a@bull.net>
> > > I could not think of anything simple so far and I'm open for suggestions.
> >
> > GFP_KERNEL should not fail, it will just block no ?
>
> No it won't block and will fail (returns NULL).
hrm... it used to never fail.. that may have changed. But it will
definitely block and try very hard to push things out to make space,
which is the whole point :-)
> I will have to add that back as there is no more fallback.
Well, the must be one in the case the tree isn't initialized yet, so if
there's an allocation failure, you may "de-initialize" it or
something... Or you can fallback if you don't find, as easy, probably
easier since it shouldn't happen in practice.
> > I don't know if it's worth trying to fire off a new
> > allocation attempt later, probably not.
>
> I've been pondering with this lately, but I think that adding a linear
> lookup fallback should be OK.
Yup.
Cheers,
Ben.
next prev parent reply other threads:[~2008-09-04 7:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-06 13:30 [PATCH 0/2 V3] powerpc - Make the irq reverse mapping tree lockless Sebastien Dugue
2008-08-06 13:30 ` [PATCH 1/2] powerpc - Separate the irq radix tree insertion and lookup Sebastien Dugue
2008-08-20 5:21 ` Benjamin Herrenschmidt
2008-09-03 13:34 ` Sebastien Dugue
2008-08-06 13:30 ` [PATCH 2/2] powerpc - Make the irq reverse mapping radix tree lockless Sebastien Dugue
2008-08-20 5:22 ` Benjamin Herrenschmidt
2008-09-03 13:34 ` Sebastien Dugue
2008-08-20 5:23 ` Benjamin Herrenschmidt
2008-09-03 13:41 ` Sebastien Dugue
2008-09-04 2:52 ` Benjamin Herrenschmidt
2008-09-04 7:22 ` Sebastien Dugue
2008-09-04 7:34 ` Benjamin Herrenschmidt [this message]
2008-09-04 7:55 ` Sebastien Dugue
2008-09-04 7:58 ` Benjamin Herrenschmidt
2008-09-04 8:04 ` Sebastien Dugue
-- strict thread matches above, loose matches on Subject: below --
2008-09-04 12:37 [PATCH 0/2 V4] powerpc - Make the irq reverse mapping " Sebastien Dugue
2008-09-04 12:37 ` [PATCH 2/2] powerpc - Make the irq reverse mapping radix " Sebastien Dugue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1220513643.4879.68.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=dwalker@mvista.com \
--cc=gilles.carry@ext.bull.net \
--cc=jean-pierre.dion@bull.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-users@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=michael@ellerman.id.au \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=sebastien.dugue@bull.net \
--cc=tglx@linutronix.de \
--cc=tinytim@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).