From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Rafal Jaworowski <raj@semihalf.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH v3 1/4] powerpc: Introduce local (non-broadcast) forms of tlb invalidates
Date: Fri, 05 Sep 2008 07:30:06 +1000 [thread overview]
Message-ID: <1220563806.4879.82.camel@pasglop> (raw)
In-Reply-To: <48C03439.1000301@semihalf.com>
On Thu, 2008-09-04 at 21:17 +0200, Rafal Jaworowski wrote:
> Kumar Gala wrote:
> [...]
> > The intent of this change is to handle SMP based invalidates via IPIs instead
> > of broadcasts as the mechanism scales better for larger number of cores.
>
> Hi Kumar,
>
> How is the inter-IPI deadlock avoidance designed in this new approach? I don't
> know the close details of low-level Book-E VM design in Linux, but am thinking
> about a scenario when we have two TLB misses hitting almost immediately on two
> different cores and they both want to send a TLB invalidate IPI to each other.
> How do you manage this?
Simple.. Just look how it's done on x86 :-) The flush_tlb_* operations
happen with interrupt enabled and no major lock held. They shouldn't
deadlock.
> The reason I ask is we had similar considerations (and problems) when bringing
> SMP to the dual core e500 on FreeBSD and ended up not using IPIs, at least for
> now, because of such concerns (and actual problems of this kind).
Well, it depends how your VM is designed. The linux one has beeing doing
IPIs for invalidations forever on x86 so it's not hard to adapt.
Ben.
prev parent reply other threads:[~2008-09-04 21:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-03 18:09 [PATCH v3 1/4] powerpc: Introduce local (non-broadcast) forms of tlb invalidates Kumar Gala
2008-09-03 18:09 ` [PATCH v3 2/4] powerpc: Fixes for CONFIG_PTE_64BIT for SMP support Kumar Gala
2008-09-03 18:09 ` [PATCH v3 3/4] powerpc/fsl-booke: Fixup 64-bit PTE reading " Kumar Gala
2008-09-03 18:09 ` [PATCH v3 4/4] powerpc/mm: Implement _PAGE_SPECIAL & pte_special() for 32-bit Kumar Gala
2008-09-04 3:15 ` Benjamin Herrenschmidt
2008-09-04 3:14 ` [PATCH v3 3/4] powerpc/fsl-booke: Fixup 64-bit PTE reading for SMP support Benjamin Herrenschmidt
2008-09-04 3:12 ` [PATCH v3 2/4] powerpc: Fixes for CONFIG_PTE_64BIT " Benjamin Herrenschmidt
2008-09-05 19:44 ` Kumar Gala
2008-09-05 22:38 ` Benjamin Herrenschmidt
2008-09-06 15:32 ` Kumar Gala
2008-09-04 19:17 ` [PATCH v3 1/4] powerpc: Introduce local (non-broadcast) forms of tlb invalidates Rafal Jaworowski
2008-09-04 21:30 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1220563806.4879.82.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=raj@semihalf.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).