linuxppc-dev.lists.ozlabs.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: 2.6.27-rc5-mm1 mystery trace
Date: Fri, 05 Sep 2008 13:54:22 +1000	[thread overview]
Message-ID: <1220586862.4879.123.camel@pasglop> (raw)
In-Reply-To: <20080904202032.2299c2c8.akpm@linux-foundation.org>


> a) someone broke powerpc's kallsyms processing and
> 
> b) someone screwed up their procfs handling.

I think the proc bug is old, might have to do with /proc/bus/pci... 
I have that on my G5 too with 2.6.26, I think I just forgot about it..
Care to give that untested patch a try ?

powerpc: Always enable pci domains in /proc for 64 bits powerpc

This patch always enable the use of the pci domain number in /proc
on 64 bits ppc machines instead of the old pseries specific hack of
testing for the buid which is meaningless on most machines.

We also enable the compat code that makes domain 0 use the old
format for the sake of the X server.

Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
---
Index: linux-work/arch/powerpc/kernel/pci-common.c
===================================================================
--- linux-work.orig/arch/powerpc/kernel/pci-common.c	2008-09-05 13:46:09.000000000 +1000
+++ linux-work/arch/powerpc/kernel/pci-common.c	2008-09-05 13:49:46.000000000 +1000
@@ -53,8 +53,9 @@ static int global_phb_number;		/* Global
 /* ISA Memory physical address */
 resource_size_t isa_mem_base;
 
-/* Default PCI flags is 0 */
-unsigned int ppc_pci_flags;
+/* Default PCI flags is 0 on ppc32, modified at boot on ppc64 */
+unsigned int ppc_pci_flags = 0;
+
 
 struct pci_controller *pcibios_alloc_controller(struct device_node *dev)
 {
@@ -669,15 +670,12 @@ void __devinit pci_process_bridge_OF_ran
 int pci_proc_domain(struct pci_bus *bus)
 {
 	struct pci_controller *hose = pci_bus_to_host(bus);
-#ifdef CONFIG_PPC64
-	return hose->buid != 0;
-#else
+
 	if (!(ppc_pci_flags & PPC_PCI_ENABLE_PROC_DOMAINS))
 		return 0;
 	if (ppc_pci_flags & PPC_PCI_COMPAT_DOMAIN_0)
 		return hose->global_number != 0;
 	return 1;
-#endif
 }
 
 void pcibios_resource_to_bus(struct pci_dev *dev, struct pci_bus_region *region,

  parent reply	other threads:[~2008-09-05  3:54 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-05  3:20 2.6.27-rc5-mm1 mystery trace Andrew Morton
2008-09-05  3:42 ` Benjamin Herrenschmidt
2008-09-05  3:49   ` Andrew Morton
2008-09-05  4:36     ` Benjamin Herrenschmidt
2008-09-05  4:41       ` Andrew Morton
2008-09-05  9:27         ` Geert Uytterhoeven
2008-09-05  9:31         ` Benjamin Herrenschmidt
2008-09-05  3:54 ` Benjamin Herrenschmidt [this message]
2008-09-05  4:04   ` Andrew Morton
2008-09-05  4:37     ` Benjamin Herrenschmidt
2008-09-08  6:11 ` Paul Mackerras
2008-09-08  6:54   ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1220586862.4879.123.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=akpm@linux-foundation.org \
    --cc=linuxppc-dev@ozlabs.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).