From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Victor Gallardo <vgallardo@amcc.com>
Cc: linuxppc-dev@ozlabs.org, Feng Kan <fkan@amcc.com>
Subject: Re: [PATCH] ibm_newemac: Add support for GPCS, SGMII and M88E1112 PHY
Date: Mon, 08 Sep 2008 10:29:14 +1000 [thread overview]
Message-ID: <1220833754.4879.228.camel@pasglop> (raw)
In-Reply-To: <1220658734-13944-1-git-send-email-vgallardo@amcc.com>
On Fri, 2008-09-05 at 16:52 -0700, Victor Gallardo wrote:
> From: Victor Gallardo <vgallardo@amcc.com>
>
> This patch adds GPCS, SGMII and M88E1112 PHY support
> for the AMCC PPC460GT/EX processors.
So if I understand the patch correctly, either there is an *MII PHY in
which case phy_address is used, or there's a GPCS one and phy_address is
-1 and gpcs_address is used right ?
Why not instead always use phy_address, and have a flag indicating
whether it's an MII or GPCS PHY ? This would avoid the added
gpcs_read/write functions, among other things, and I believe would look
cleaner... Or am I missing something ?
Cheers,
Ben.
next prev parent reply other threads:[~2008-09-08 0:29 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-05 23:52 [PATCH] ibm_newemac: Add support for GPCS, SGMII and M88E1112 PHY Victor Gallardo
2008-09-08 0:29 ` Benjamin Herrenschmidt [this message]
2008-09-08 5:57 ` [PATCH] ibm_newemac: Add support for GPCS, SGMII and M88E1112PHY Victor Gallardo
2008-09-09 7:12 ` Benjamin Herrenschmidt
2008-09-15 23:39 ` [PATCH] ibm_newemac: Add support for GPCS, SGMII andM88E1112PHY Victor Gallardo
-- strict thread matches above, loose matches on Subject: below --
2008-09-05 23:55 [PATCH] ibm_newemac: Add support for GPCS, SGMII and M88E1112 PHY Victor Gallardo
2008-09-13 19:41 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1220833754.4879.228.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=fkan@amcc.com \
--cc=linuxppc-dev@ozlabs.org \
--cc=vgallardo@amcc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).