From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: James Bottomley <James.Bottomley@HansenPartnership.com>
Cc: linuxppc-dev@ozlabs.org
Subject: Re: [PATCH] fix compile failure with non modular builds
Date: Wed, 10 Sep 2008 10:46:39 +1000 [thread overview]
Message-ID: <1221007599.14835.16.camel@pasglop> (raw)
In-Reply-To: <1221005505.23271.18.camel@localhost.localdomain>
On Tue, 2008-09-09 at 19:11 -0500, James Bottomley wrote:
> On Wed, 2008-09-10 at 10:09 +1000, Benjamin Herrenschmidt wrote:
> > On Tue, 2008-09-09 at 19:04 -0500, James Bottomley wrote:
> > > commit deac93df26b20cf8438339b5935b5f5643bc30c9
> > > Author: James Bottomley <James.Bottomley@HansenPartnership.com>
> > > Date: Wed Sep 3 20:43:36 2008 -0500
> > >
> > > lib: Correct printk %pF to work on all architectures
> > >
> > > Broke the non modular builds by moving an essential function into
> > > modules.c. Fix this by moving it out again and into asm/sections.h as
> > > an inline. To do this, the definition of struct ppc64_opd_entry has
> > > been lifted out of modules.c and put in asm/elf.h where it belongs.
> > >
> > > Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
> >
> > Ouch. Ack.
>
> Actually, this is for your powerpc tree, so we actually run it through
> some extended config testing this time ...
Or rather Paul's tree :-)
He's on the way to Portland and I'm flying out tomorrow, but I'll make
sure it gets picked up.
I must admit that none of my test configs I think has module support
turned off (even if I tend to have all the stuff I need built-in).
Cheers,
Ben.
next prev parent reply other threads:[~2008-09-10 0:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-10 0:04 [PATCH] fix compile failure with non modular builds James Bottomley
2008-09-10 0:09 ` Benjamin Herrenschmidt
2008-09-10 0:11 ` James Bottomley
2008-09-10 0:46 ` Benjamin Herrenschmidt [this message]
2008-09-10 14:50 ` Stephen Rothwell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1221007599.14835.16.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=James.Bottomley@HansenPartnership.com \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).