From: Nate Case <ncase@xes-inc.com>
To: Kumar Gala <galak@kernel.crashing.org>
Cc: linuxppc-dev@ozlabs.org, Andrew Kilkenny <akilkenny@xes-inc.com>,
Dave Jiang <djiang@mvista.com>
Subject: Re: [PATCH] edac: mpc85xx: Add support for MPC8572
Date: Fri, 19 Sep 2008 17:28:40 -0500 [thread overview]
Message-ID: <1221863320.19971.156.camel@localhost.localdomain> (raw)
In-Reply-To: <4DA3AC98-4FDC-441C-AFC4-F2E3558420A6@kernel.crashing.org>
On Fri, 2008-09-19 at 16:43 -0500, Kumar Gala wrote:
> I don't have any issue with this, but why are you marking the PCI
> error interrupt as shared?
[snip]
> this I'm a bit more skeptical about.
The only one we really need to make shared is the memory controller
interrupt. I'll drop it for the PCI and L2 interrupts in the next rev
of the patch.
> its fsl,mpc8572.. (we need to fix the others to match that convention
> as its pretty standard for other device tree nodes)
I actually started out with "fsl,mpc8572-*" but then somehow convinced
myself I was wrong when I saw fsl,85xx in so many other places :)
Thanks for the feedback. I'll correct these and re-submit.
--
Nate Case <ncase@xes-inc.com>
prev parent reply other threads:[~2008-09-19 22:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-19 21:12 [PATCH] edac: mpc85xx: Add support for MPC8572 Nate Case
2008-09-19 21:22 ` Dave Jiang
2008-09-19 21:43 ` Kumar Gala
2008-09-19 22:28 ` Nate Case [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1221863320.19971.156.camel@localhost.localdomain \
--to=ncase@xes-inc.com \
--cc=akilkenny@xes-inc.com \
--cc=djiang@mvista.com \
--cc=galak@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).