LinuxPPC-Dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Wolfgang Grandegger <wg@grandegger.com>
Cc: linuxppc-dev <Linuxppc-dev@ozlabs.org>
Subject: Re: irq_disable() not working
Date: Tue, 23 Sep 2008 19:20:34 +1000	[thread overview]
Message-ID: <1222161634.12085.138.camel@pasglop> (raw)
In-Reply-To: <48D8B214.2050706@grandegger.com>

On Tue, 2008-09-23 at 11:08 +0200, Wolfgang Grandegger wrote:
> I'm trying to understand how irq_disable() is supposed to work on
> PowerPC systems. Most PowerPC PIC do *not* implement the enable and
> disable, but just the unmask and mask methods, e.g:
> 
>   http://lxr.linux.no/linux+v2.6.26.5/arch/powerpc/sysdev/mpic.c#L867
> 
> The irq_disable() function will then call the default function
> default_disable():
> 
>   http://lxr.linux.no/linux+v2.6.26.5/kernel/irq/chip.c#L234
> 
> which does not *nothing*. I do not see how the interrupt gets disabled
> on the hardware level. Obviously I have missed something. TIA for
> clarification.

Lazy masking ? ie, look what happens if the irq happens while disabled.

Ben.

      reply	other threads:[~2008-09-23  9:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-23  9:08 irq_disable() not working Wolfgang Grandegger
2008-09-23  9:20 ` Benjamin Herrenschmidt [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1222161634.12085.138.camel@pasglop \
    --to=benh@kernel.crashing.org \
    --cc=Linuxppc-dev@ozlabs.org \
    --cc=wg@grandegger.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox