From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Remi Machet <rmachet@slac.stanford.edu>
Cc: Linux PPC <linuxppc-dev@ozlabs.org>
Subject: Re: New dma-noncoherent code, looking for comment and people to test
Date: Tue, 30 Sep 2008 17:21:11 +1000 [thread overview]
Message-ID: <1222759271.9006.45.camel@pasglop> (raw)
In-Reply-To: <1222709165.8628.4.camel@pcds-ts102.slac.stanford.edu>
On Mon, 2008-09-29 at 10:26 -0700, Remi Machet wrote:
>
> I also removed the HIGHMEM support in dma_sync since memory allocated for
> DMA transfer should always be in ZONE_DMA (ie not in ZONE_HIGHMEM).
While I like the idea of simplifying that stuff, the above sentence is
incorrect unfortunately.
ZONE_DMA is an artifact of x86 ISA DMA limitations. You -will- get
request for mapping pages for DMA that have been allocated within
different zones (notably highmem).
The problem with highmem is that whether you can or not DMA to/from
highmem is somewhat unclear, drivers set flags individually in various
layers to allow it, which is definitely not the right place to do so. So
while it would be nice to think we never will, in practice, we do.
> Looking forward to any comment about why this code may not work or is not
> as good as the original. If you do test this code on your platform, let me
> know how it goes ... if no-one object and no bug is found I will submit
> this patch in a month or so.
Ben.
next prev parent reply other threads:[~2008-09-30 7:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-09-29 17:26 New dma-noncoherent code, looking for comment and people to test Remi Machet
2008-09-29 18:03 ` Kumar Gala
2008-09-29 18:22 ` Remi Machet
2008-09-29 18:39 ` Kumar Gala
2008-09-30 7:21 ` Benjamin Herrenschmidt
2008-09-30 7:21 ` Benjamin Herrenschmidt [this message]
2008-09-30 16:27 ` Remi Machet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1222759271.9006.45.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=rmachet@slac.stanford.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).