From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: linuxppc-dev@ozlabs.org, tony.luck@intel.com, linux-pci@vger.kernel.org
Subject: Re: [RFC/PATCH 2/2] powerpc: Add legacy PCI access via sysfs
Date: Sat, 04 Oct 2008 08:16:03 +1000 [thread overview]
Message-ID: <1223072163.12264.215.camel@pasglop> (raw)
In-Reply-To: <200810031509.44407.jbarnes@virtuousgeek.org>
On Fri, 2008-10-03 at 15:09 -0700, Jesse Barnes wrote:
> On Friday, October 3, 2008 2:52 pm Benjamin Herrenschmidt wrote:
> > On Fri, 2008-10-03 at 08:59 -0700, Jesse Barnes wrote:
> > > Feel free to change the generic code if it makes things easier for you,
> > > the only limitation is that we have to live within the generic sysfs
> > > read/write functions. Obviously I didn't worry about it when doing this
> > > code on ia64...
> >
> > I started to do that and then decided not to bother...
>
> Well than you can at least update the comment in the ppc platform code
> from "The generic code is idiotic" to "The generic code is idiotic and I'm
> too lazy to fix it". :)
Meuhh... Ok, I'll have another look. The main reason I didn't want to
change it was that I didn't want to have to fix ia64 more than I already
did :-)
Cheers,
Ben.
prev parent reply other threads:[~2008-10-03 22:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-03 9:49 [RFC/PATCH 2/2] powerpc: Add legacy PCI access via sysfs Benjamin Herrenschmidt
2008-10-03 15:59 ` Jesse Barnes
2008-10-03 21:52 ` Benjamin Herrenschmidt
2008-10-03 22:09 ` Jesse Barnes
2008-10-03 22:16 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1223072163.12264.215.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=jbarnes@virtuousgeek.org \
--cc=linux-pci@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).