From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from gate.crashing.org (gate.crashing.org [63.228.1.57]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id 4EBBBDDE1A for ; Sat, 4 Oct 2008 08:16:11 +1000 (EST) Subject: Re: [RFC/PATCH 2/2] powerpc: Add legacy PCI access via sysfs From: Benjamin Herrenschmidt To: Jesse Barnes In-Reply-To: <200810031509.44407.jbarnes@virtuousgeek.org> References: <20081003094953.A7F4EDE184@ozlabs.org> <200810030859.12335.jbarnes@virtuousgeek.org> <1223070723.12264.213.camel@pasglop> <200810031509.44407.jbarnes@virtuousgeek.org> Content-Type: text/plain Date: Sat, 04 Oct 2008 08:16:03 +1000 Message-Id: <1223072163.12264.215.camel@pasglop> Mime-Version: 1.0 Cc: linuxppc-dev@ozlabs.org, tony.luck@intel.com, linux-pci@vger.kernel.org Reply-To: benh@kernel.crashing.org List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Fri, 2008-10-03 at 15:09 -0700, Jesse Barnes wrote: > On Friday, October 3, 2008 2:52 pm Benjamin Herrenschmidt wrote: > > On Fri, 2008-10-03 at 08:59 -0700, Jesse Barnes wrote: > > > Feel free to change the generic code if it makes things easier for you, > > > the only limitation is that we have to live within the generic sysfs > > > read/write functions. Obviously I didn't worry about it when doing this > > > code on ia64... > > > > I started to do that and then decided not to bother... > > Well than you can at least update the comment in the ppc platform code > from "The generic code is idiotic" to "The generic code is idiotic and I'm > too lazy to fix it". :) Meuhh... Ok, I'll have another look. The main reason I didn't want to change it was that I didn't want to have to fix ia64 more than I already did :-) Cheers, Ben.